-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] update expo packages to SDK 51 versions #2530
base: 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available
Are you sure you want to change the base?
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @szdziedzic and the rest of your teammates on Graphite |
Size Change: -242 kB (-0.46%) Total Size: 52.7 MB
|
ad28019
to
28c6181
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the failing tests are resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double check test failures before landing.
b5f49ac
to
9cd41f7
Compare
28c6181
to
32b6ffa
Compare
|
e5b2666
to
c72bac0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 09-02-_eas-cli_use_getconfig_from_projectdir_node_modules__expo_config_if_available #2530 +/- ##
====================================================================================================================
Coverage 53.10% 53.10%
====================================================================================================================
Files 564 564
Lines 21508 21508
Branches 4207 4207
====================================================================================================================
Hits 11420 11420
Misses 10058 10058
Partials 30 30 ☔ View full report in Codecov by Sentry. |
da4d277
to
8536a7a
Compare
c72bac0
to
37edc6d
Compare
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Why
update expo packages to SDK 51 versions
revert #2524
How
update expo packages to SDK 51 versions
Test Plan
tests