Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env:pull uses local values of encrypted variables #2656

Conversation

khamilowicz
Copy link
Contributor

Why

ENG-13929: eas env:pull overwrites all variables

env:pull should not overwrite existing values for encrypted variables, but leave them in .env.local.

Test Plan

Tested manually

Copy link

linear bot commented Oct 24, 2024

@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Oct 24, 2024
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @sjchmiela

Generated by CodeMention

Copy link

github-actions bot commented Oct 24, 2024

Size Change: +501 B (0%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB +501 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (a212662) to head (d41ee53).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 13.34% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
- Coverage   53.01%   52.91%   -0.10%     
==========================================
  Files         567      570       +3     
  Lines       21647    21750     +103     
  Branches     4242     4263      +21     
==========================================
+ Hits        11474    11506      +32     
- Misses      10143    10213      +70     
- Partials       30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/eas-cli/src/commands/env/pull.ts Outdated Show resolved Hide resolved
@khamilowicz khamilowicz force-pushed the piotrekszeremeta/eng-13929-eas-envpull-overwrites-all-variables branch from ca2d3ec to d41ee53 Compare October 25, 2024 14:54
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@khamilowicz khamilowicz merged commit 5478814 into main Oct 25, 2024
10 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/eng-13929-eas-envpull-overwrites-all-variables branch October 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants