Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use lcovonly reporter for the test-ci script #584

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

Phillip9587
Copy link
Contributor

The lcov reporter generates the lcov.info file and a html report. We can skip creating the html report and use the lcovonly reporter.

Copy link
Member

@jonchurch jonchurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we're only uploading the lcov.info file in CI but generating:

coverage
├── lcov-report
│   ├── base.css
│   ├── block-navigation.js
│   ├── body-parser
│   │   ├── index.html
│   │   ├── index.js.html
│   │   └── lib
│   │       ├── index.html
│   │       ├── read.js.html
│   │       └── types
│   │           ├── index.html
│   │           ├── json.js.html
│   │           ├── raw.js.html
│   │           ├── text.js.html
│   │           └── urlencoded.js.html
│   ├── favicon.png
│   ├── index.html
│   ├── prettify.css
│   ├── prettify.js
│   ├── sort-arrow-sprite.png
│   └── sorter.js
└── lcov.info

For local checking, we have a separate script npm run test-cov

@jonchurch jonchurch merged commit d127b9c into expressjs:master Feb 19, 2025
12 checks passed
@Phillip9587 Phillip9587 deleted the ci-lcovonly-reporter branch February 19, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants