Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better building of highlighting parameters #214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better building of highlighting parameters #214

wants to merge 1 commit into from

Conversation

gggeek
Copy link
Collaborator

@gggeek gggeek commented Mar 18, 2018

  • do not inject any hl parameter unless needed
  • make it easier to alter build of hl parameters in subclasses

avoid sending *any* hl parameter to solr when not required & make it …
775ea98 
…easy to extend hl param build in subclasses
@pkamps
Copy link
Contributor

pkamps commented Mar 24, 2018

I like it. ezfind has so much potential for those types of enhancements.
+1

@pkamps pkamps mentioned this pull request Jun 10, 2018
Merged
@peterkeung peterkeung mentioned this pull request Aug 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crevillo crevillo crevillo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gggeek @pkamps @crevillo