IBX-6221: removed duplicate conditions from isFieldEmpty visitor #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Looks good.
We need some basic unit test coverage for that use case, specifically for that FieldEmpty Visitor, showcasing the bug. The test should create a Criterion which caused duplication and check if the output is as expected.
So, expecting to see new tests/Query/Common/CriterionVisitor/Field/FieldEmptyTest.php :)
Please cover just the essence of the bug - I know we could do much more there but that's on us - maintainers :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.ibexa.co/browse/IBX-6221
Removes duplicate sql conditions from
FieldEmpty->visit(does not affect query result but shortens query that is send to solr)