Added constraint to signup form - No whitespace in username (#519)

* Added constraint to username so that no whitespaces can be in the username. Django handles trailing and leading whitespaces it selfs, so that '-test10' all leadingwhite spaces is ingored by django when inserted. The same with 'test10-' all trailing is also ingored

* fixup! Added constraint to username so that no whitespaces can be in the username. Django handles trailing and leading whitespaces it selfs, so that '-test10' all leadingwhite spaces is ingored by django when inserted. The same with 'test10-' all trailing is also ingored

* Update comment

---------

Co-authored-by: Christoffer Trebbien Jønsson <[email protected]>
Co-authored-by: Kresten Laust <[email protected]>

stregsystem/forms.py

@@ -108,6 +108,7 @@ class Meta:
             'username': {
                 'required': 'Udfyldning af `Brugernavn` er påkrævet.',
                 'max_length': 'Længden af `Brugernavn` må ikke overstige 16 tegn.',
+                'invalid_username': 'Det indtastede `Brugernavn` må ikke indholde whitespaces',
             },
             'email': {
                 'required': 'Udfyldning af `E-Mail` er påkrævet.',

stregsystem/migrations/0020_alter_member_username.py

@@ -0,0 +1,19 @@
+# Generated by Django 4.1.13 on 2024-10-24 19:07
+
+import django.core.validators
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('stregsystem', '0019_theme'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='member',
+            name='username',
+            field=models.CharField(max_length=16, validators=[django.core.validators.RegexValidator(code='invalid_username', regex='^\\S+$')]),
+        ),
+    ]

stregsystem/models.py

@@ -163,7 +163,13 @@ class Member(models.Model):  # id automatisk...
         ('F', 'Female'),
     )
     active = models.BooleanField(default=True)
-    username = models.CharField(max_length=16)
+
+    no_whitespace_validator = RegexValidator(
+        # This regex checks for whitespace in the username
+        regex=r'^\S+$',
+        code='invalid_username',
+    )
+    username = models.CharField(max_length=16, validators=[no_whitespace_validator])
     year = models.CharField(max_length=4, default=get_current_year)  # Put the current year as default
     firstname = models.CharField(max_length=20)  # for 'firstname'
     lastname = models.CharField(max_length=30)  # for 'lastname'