-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Activate Fklub Theme #512
Conversation
Ideas for alternative triggers:
Alternative names:
|
I think it might run the issue that some people see their account as deactivated, perhaps it should have a slightly different text, such as "Look up Patch Tuesday for more info" |
Other than that, hilarious and I love it. |
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.js
Outdated
Show resolved
Hide resolved
That was not supposed to be individual comments, but here we are. They are just nitpicks, you don't have to fix them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice theme!
I have some nitpicks here that you don't need to fix, but if you don't, I will probably fix them in a follow-up PR :)
stregsystem/templates/stregsystem/themes/activatefklub/activatefklub.html
Outdated
Show resolved
Hide resolved
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
@soupglasses Merge? |
:( |
I did not review this |
It seems someone has forgotten to pay to activate our F-klub account, so an effective reminder strategy has been added to help encourage that to change. Set to remind us every patch tuesday. 🪟 😄