Add Activate Fklub Theme #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideas for alternative triggers:
Alternative names:
|
|
I think it might run the issue that some people see their account as deactivated, perhaps it should have a slightly different text, such as "Look up Patch Tuesday for more info" |
|
Other than that, hilarious and I love it. |
|
Updated phrase to no longer reference an account to avoid such confusion.
|
atjn
reviewed
Oct 8, 2024
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
atjn
reviewed
Oct 8, 2024
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.js
Outdated
Show resolved
Hide resolved
|
That was not supposed to be individual comments, but here we are. They are just nitpicks, you don't have to fix them. |
atjn
approved these changes
Oct 8, 2024
stregsystem/templates/stregsystem/themes/activatefklub/activatefklub.html
Outdated
Show resolved
Hide resolved
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
stregsystem/static/stregsystem/themes/activatefklub/activatefklub.css
Outdated
Show resolved
Hide resolved
|
@soupglasses Merge? |
|
:( |
|
I did not review this |
|
Squash :(( |
|
Oof :( Maybe a good idea to disable "default merge" in project settings if it is not to be used?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems someone has forgotten to pay to activate our F-klub account, so an effective reminder strategy has been added to help encourage that to change. Set to remind us every patch tuesday. 🪟 😄