-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UserService 작성 #13
Merged
Merged
UserService 작성 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lyan
reviewed
Jan 30, 2023
bbaemin-api/src/main/java/org/bbaemin/user/controller/UserController.java
Show resolved
Hide resolved
f-lab-lyan
reviewed
Jan 30, 2023
bbaemin-api/src/main/java/org/bbaemin/user/controller/UserController.java
Show resolved
Hide resolved
f-lab-lyan
reviewed
Jan 30, 2023
bbaemin-api/src/main/java/org/bbaemin/user/controller/request/JoinRequest.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Jan 30, 2023
bbaemin-api/src/main/java/org/bbaemin/user/controller/response/UserResponse.java
Show resolved
Hide resolved
f-lab-lyan
reviewed
Jan 30, 2023
bbaemin-api/src/test/java/org/bbaemin/user/service/UserServiceTest.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Feb 2, 2023
bbaemin-api/src/main/java/org/bbaemin/user/repository/UserRepository.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Feb 2, 2023
bbaemin-api/src/test/java/org/bbaemin/user/service/UserServiceTest.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Feb 2, 2023
bbaemin-api/src/main/java/org/bbaemin/user/service/UserService.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Feb 2, 2023
bbaemin-api/src/main/java/org/bbaemin/user/repository/UserMemoryRepository.java
Outdated
Show resolved
Hide resolved
f-lab-lyan
reviewed
Feb 13, 2023
bbaemin-api/src/test/java/org/bbaemin/user/controller/response/UserResponseTest.java
Show resolved
Hide resolved
f-lab-lyan
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 코드는 코드 자체는 문제는 없어보여서 추가 사항에 대해서는 다른 PR로 작업해도 될 것 같습니다.
CHANEE-personal
pushed a commit
to CHANEE-personal/bbaemin
that referenced
this pull request
Feb 18, 2023
* UserService/UserServiceTest 작성 * request/response DTO Service에서 제거 * Entity에서 비즈니스 로직 제거 * UserResponse 필드 테스트 * UserMemoryRepository - id 타입 AtomicLong으로 변경 * toEntity 제거
yeonkyungJoo
added a commit
that referenced
this pull request
Feb 25, 2023
* 1. build gradle jpa 관련 추가 2. application yml db 관련 설정 추가 * dev db 관련 암호화 적용 * 1. root build gradle jpa 설정 관련 및 db 관련 추가 2. application yml dev, test 분리 3. yml password 암호화 관련 설정 추가 * yml jasypt 암호화 관련 설정 추가 * build gradle dependencies 알파벳순으로 정렬 * build gradle dependencies 알파벳순으로 정렬 * Category service, repository (#18) * 1. category 관련 service, repository 2. service test case * 수정 * repository method명 jpa에 맞게 수정 * 1. category vo 추가 2. create, update request builder 제거 후 VO에서 작업 3. service test case 수정 * Error 클래스 및 관련 static 메소드 추가 (#19) * Error 클래스 및 관련 static 메소드 추가 * Error 클래스를 ApiResult의 inner class로 선언 * UserService 작성 (#13) * UserService/UserServiceTest 작성 * request/response DTO Service에서 제거 * Entity에서 비즈니스 로직 제거 * UserResponse 필드 테스트 * UserMemoryRepository - id 타입 AtomicLong으로 변경 * toEntity 제거 * item service, repository (#17) * 1. item service, repository 2. item service unit test * service unit test 수정 * service mockito test 관련 수정 * repository method명 jpa에 맞게 수정 * 1. item vo 추가 2. create, update request builder 제거 후 VO에서 작업 3. service test case 수정 * 1. Category CRUD jpa 적용 2. Store CRUD jpa 적용 * repository commit * repository commit으로 revert * 매장 수정시 로직 수정 * ApiResult 적용 * category, store 수정 * toDto 삭제, eventListener 삭제 * item 연관관계 설정 * category, store 수정 * 수정 --------- Co-authored-by: yeonkyung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.