Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#91] coupon use #93

Merged
merged 23 commits into from
Mar 29, 2024
Merged

[#91] coupon use #93

merged 23 commits into from
Mar 29, 2024

Conversation

JinDDung2
Copy link
Collaborator

@JinDDung2 JinDDung2 commented Mar 25, 2024 •
edited
Loading

작업 요약

  • 쿠폰 적용 기능

작업 내용

(체크 박스를 모두 선택해야 merge가 활성화 됩니다.)

  • 쿠폰 적용하기
  • 테스트

f-lab-bot and others added 23 commits January 3, 2024 17:34
@f-lab-bot
자동 PR 리뷰를 위한 workflow 파일 추가 by f-lab
adeb0ba
@f-lab-bot
자동 PR 리뷰를 위한 workflow 파일 추가 by f-lab
bc76311
@JinDDung2
chore : 서버 마이그레이션
97d8986
@JinDDung2
Merge pull request #81 from f-lab-edu/feature/79-coupon
4600ae3 
[#79] 쿠폰 생성
@JinDDung2
config update
a79fc86
@JinDDung2
Merge pull request #84 from f-lab-edu/feature/79-coupon
8fd7d78 
redisson 설정 변경
@JinDDung2
Merge pull request #85 from f-lab-edu/feature/79-coupon
678cee8 
feature/79-coupon
@JinDDung2
[#79] refactor: 재고감소 메서드명 변경
67ab088
@JinDDung2
[fix] git 충돌 해결
ae7ad44
@JinDDung2
Merge pull request #86 from f-lab-edu/79-distributed-lock
7678298 
[#79] refactor: 재고감소 메서드명 변경
@JinDDung2
[#79] feat : 재고 부족시 예외처리
d0ed733
@JinDDung2
[#79] test : 재고 부족시 예외처리
c146402
@JinDDung2
Merge pull request #87 from f-lab-edu/79-distributed-lock
e4581b6 
[#79] feat : 재고 부족시 예외처리
@JinDDung2
[#79] feat : 선착순 쿠폰 생성 로직 변경
45d590c 
1. 락 흭득 레이어 service -> facade
2. 락 흭득 위치에 따른 메서드명 변경
* decreaseStockAndGetLock -> decreaseStock
@JinDDung2
[#79] test : 선착순 쿠폰 생성 로직 변경
6381513
@JinDDung2
Merge pull request #88 from f-lab-edu/79-distributed-lock
cb560fa 
[#79] 선착순 쿠폰 생성 로직 수정
@JinDDung2
[#79] feat : 분산 락 관심사 분리
41e93ec 
- 분산락 AOP로 커스텀 애노테이션(@distributedlock)으로 변경
- 쿠폰 생성 로직에서 락 관련 코드 제거
@JinDDung2
[#79] test : 분산 락 관심사 분리
3c063d3
@JinDDung2
Merge pull request #89 from f-lab-edu/79-distributed-lock
a1c591f 
[#79] distributed lock 관심사 분리
@JinDDung2
submoudle update
23e69cd 
- change server ip
@JinDDung2
Merge pull request #90 from f-lab-edu/79-distributed-lock
e7d4cab 
submoudle update
@JinDDung2
[#91] Feat: 쿠폰 적용하기 기능
681effa 
* 유효기간 관련 예외 내용 변경
 * (상품) 유효기간이 지남 -> 상품 유효기간이 지남
@JinDDung2
[#91] test: 쿠폰 적용하기 테스트
51c8241 
* 유효기간 관련 예외 메시지 변경
 * (상품) 유효기간이 지남 -> 상품 유효기간이 지남
@JinDDung2 JinDDung2 added the enhancement New feature or request label Mar 25, 2024
@JinDDung2 JinDDung2 requested a review from f-lab-bot March 25, 2024 07:27
@JinDDung2 JinDDung2 self-assigned this Mar 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@JinDDung2 JinDDung2 merged commit a6d27a1 into feature/79-coupon Mar 29, 2024
1 of 2 checks passed
@JinDDung2 JinDDung2 deleted the 91-coupon-use branch April 24, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-bot f-lab-bot Awaiting requested review from f-lab-bot

Assignees

@JinDDung2 JinDDung2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JinDDung2 @f-lab-bot