This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#45] Item 조회 메서드에 대한 로컬캐싱 적용 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jjeda
commented
Jan 14, 2020
jjeda
commented
- ehcache 적용
- getItem() 메서드에 대한 캐시적용 및 refresh 용 메서드생성
- ehcache 적용 - getItem() 메서드에 대한 캐시적용 및 refresh 용 메서드생성
f-lab-dev
reviewed
Jan 14, 2020
| @@ -31,10 +35,14 @@ public Item saveItem(ItemDto itemDto) { | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| @Cacheable(value = "findItemCache",key ="#itemId") | |||
| public Optional<Item> getItem(Long itemId) { | |||
There was a problem hiding this comment.
이곳에 캐싱을 걸어준 이유가 같이 들어있으면 좋을 것 같습니다~
| eternal="false" | ||
| diskSpoolBufferSizeMB="20" | ||
| timeToIdleSeconds="300" timeToLiveSeconds="600" | ||
| memoryStoreEvictionPolicy="LFU" |
| updateCheck="false"> | ||
| <diskStore path="java.io.tmpdir" /> | ||
|
|
||
| <cache name="findItemCache" |
There was a problem hiding this comment.
각 옵션에 대한 설명과 사용 이유도 주석으로 있으면 좋을 것 같습니다.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.