109 v100 waypoint follow example results in frequent crashes #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapt reset modes to be "<ref_line>_<reset_fn>_<shuffle>" and update tests/examples accordingly, use None as defaults in reset and observation such that we have the choice of default in factory methods.
nandantumu
requested changes
Jan 30, 2024
This reverts commit ff7a3a1
|
Right, sorry for that. I reverted the "linting" commit. @nandantumu please check again. |
|
LGTM |
luigiberducci
deleted the
109-v100-waypoint-follow-example-results-in-frequent-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor automatic reset, proposed convention is to call the reset type as "":
I have also removed some tests which end up in the wrong directory (probably unwanted merge).
Closes #109