Merge pull request #57 from f3l/056_showAllQuotes

Fix pagination and add test
f3l · Jan 12, 2019 · ea17caa · ea17caa
2 parents 111d6bb + 17b1d9f
commit ea17caa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/source/citesystem/server/paginationinfo.d b/source/citesystem/server/paginationinfo.d
@@ -16,7 +16,7 @@ public struct PaginationInfo {
     @property
     size_t lastPage() const {
         auto numberOfFullPages = numberOfElements / pagesize;
-        if (numberOfFullPages % pagesize == 0) {
+        if (numberOfElements % pagesize != 0) {
             return numberOfFullPages + 1;
         } else {
             return numberOfFullPages;

diff --git a/test/citesystem/testpaginationinfo.d b/test/citesystem/testpaginationinfo.d
@@ -14,6 +14,16 @@ private import citesystem.server.paginationinfo : PaginationInfo;
     actualLastPage.shouldEqual(expectedLastPage);
 }
 
+@("Last page calculation, actual case")
+@system unittest {
+    const testPaginationInfo = PaginationInfo(1, 10, 52);
+    const actualLastPage = testPaginationInfo.lastPage;
+    const expectedLastPage = 6;
+
+    actualLastPage.shouldEqual(expectedLastPage);
+}
+
+
 @("Last page calculation, harder case")
 @system unittest {
     const testPaginationInfo = PaginationInfo(1, 10, 105);