Fix wrong parameter in get_part_resources()

[MidsummerNight]

The assertion error for get_part_resources() should print res_mapping instead of part_mapping (the latter isn't even defined in get_part_resources()). See #1834 for details.

[acomodi]

@MidsummerNight Thanks for this fix!

There is the DCO check failing (https://stackoverflow.com/questions/25570947/how-to-use-git-interactive-rebase-for-signing-off-a-series-of-commits).

On an additional note the usual workflow is to:

• create a new branch starting from the upstream master one
• from the branch open the PR
• if any update lands on upstream master, rebase the branch on top of it

Stack Overflow

How to use git interactive rebase for signing off a series of commits

I would like to sign off all commits on a branch that I have finished and want to send to an upstream project (e.g. via a pull request on GitHub).

A recommended way I've found is to use

git rebas...

[acomodi]

@MidsummerNight Sign off should be applied to all commits in the PR. Actually I think you could squash all of them into a single commit (https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git)

Stack Overflow

Squash my last X commits together using Git

How can I squash my last X commits together into one commit using Git?

[MidsummerNight]

Ugh somehow Tim's Kintex commit got inside......

[MidsummerNight]

I ran gh pr checkout 1835, then git rebase HEAD~5 --signoff followed by git push --force-with-lease origin master as the DCO check page told me. Maybe I should've used HEAD~4 instead of 5...

[acomodi]

I think you may create a new branch from the current HEAD, commit your change with the sign-off and open a new PR

[MidsummerNight]

Yeah that would be a better way. Will do more research on Git and create a new PR tomorrow.

[MidsummerNight]

Filed #1836 with correct sign-off to replace this one. I'll make sure to always sign off properly in future PRs.