Skip to content

Commit

Permalink
gha: fix node deprecation warning (#368)
Browse files Browse the repository at this point in the history
* gha: fix node deprecation warning

* gha: more fixes
  • Loading branch information
csegarragonz authored Jan 26, 2024
1 parent 62c022d commit 56c8c45
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
image: [faabric, planner]
steps:
- name: "Get the code"
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: "Get tag version"
run: echo "TAG_VERSION=${GITHUB_REF#refs/tags/v*}" >> $GITHUB_ENV
- name: "Print tag version"
Expand Down
26 changes: 17 additions & 9 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ jobs:
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
steps:
- uses: faasm/conan-cache-action@v1
- name: "Check-out code"
uses: actions/checkout@v4
- uses: faasm/conan-cache-action@v3
- name: "Build Conan CMake deps to be shared by all runs"
run: ./bin/inv_wrapper.sh dev.cmake --build Debug --clean

Expand All @@ -39,7 +41,7 @@ jobs:
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
steps:
- name: "Check out code"
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: "Build docs"
run: ./bin/inv_wrapper.sh docs

Expand All @@ -53,7 +55,7 @@ jobs:
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
steps:
- name: "Check out code"
uses: actions/checkout@v3
uses: actions/checkout@v4
# We need to set the safe git directory as formatting relies on git-ls
# See actions/checkout#766
- name: "Set the GH workspace as a safe git directory"
Expand All @@ -79,7 +81,9 @@ jobs:
redis:
image: redis
steps:
- uses: faasm/conan-cache-action@v1
- name: "Check-out code"
uses: actions/checkout@v4
- uses: faasm/conan-cache-action@v3
- name: "Ping redis"
run: redis-cli -h redis ping
- name: "Run cmake for tests"
Expand Down Expand Up @@ -119,7 +123,9 @@ jobs:
redis:
image: redis
steps:
- uses: faasm/conan-cache-action@v1
- name: "Check-out code"
uses: actions/checkout@v4
- uses: faasm/conan-cache-action@v3
- name: "Ping redis"
run: redis-cli -h redis ping
- name: "Run cmake for tests"
Expand All @@ -137,16 +143,16 @@ jobs:
CONAN_CACHE_MOUNT_SOURCE: ~/.conan/
steps:
- name: "Log in to ACR"
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: faasm.azurecr.io
username: ${{ secrets.ACR_SERVICE_PRINCIPAL_ID }}
password: ${{ secrets.ACR_SERVICE_PRINCIPAL_PASSWORD }}
# --- Code update ---
- name: "Check out code"
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: "Conan cache"
uses: faasm/conan-cache-action@v1
uses: faasm/conan-cache-action@v3
- name: "Build distributed tests"
run: ./dist-test/build.sh
- name: "Run the distributed tests"
Expand All @@ -172,7 +178,9 @@ jobs:
redis:
image: redis
steps:
- uses: faasm/conan-cache-action@v1
- name: "Check-out code"
uses: actions/checkout@v4
- uses: faasm/conan-cache-action@v3
with:
build-type: "release"
- name: "Run cmake shared"
Expand Down

0 comments on commit 56c8c45

Please sign in to comment.