nits: self-review

faasm · Mar 13, 2024 · d17b849 · d17b849
1 parent bf65d1f
commit d17b849
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/mpi/MpiWorld.cpp b/src/mpi/MpiWorld.cpp
@@ -94,7 +94,7 @@ MpiMessage MpiWorld::recvRemoteMpiMessage(int sendRank, int recvRank)
         throw e;
     }
 
-    // TODO: make sure we minimze copies here
+    // TODO(mpi-opt): make sure we minimze copies here
     MpiMessage parsedMsg;
     parseMpiMsg(msg, &parsedMsg);
 
@@ -1414,10 +1414,9 @@ void MpiWorld::probe(int sendRank, int recvRank, MPI_Status* status)
     /*
     const std::shared_ptr<InMemoryMpiQueue>& queue =
       getLocalQueue(sendRank, recvRank);
-    // 30/12/21 - Peek will throw a runtime error
     std::shared_ptr<MPIMessage> m = *(queue->peek());
 
-    // faabric_datatype_t* datatype = getFaabricDatatypeFromId(m->type());
+    faabric_datatype_t* datatype = getFaabricDatatypeFromId(m->type());
     status->bytesSize = m->count() * datatype->size;
     status->MPI_ERROR = 0;
     status->MPI_SOURCE = m->sender();
@@ -1474,7 +1473,7 @@ void MpiWorld::initLocalQueues()
     }
 }
 
-// TODO: double-check that the fast (no-async) path is fast
+// TODO(mpi-opt): double-check that the fast (no-async) path is fast
 MpiMessage MpiWorld::recvBatchReturnLast(int sendRank,
                                          int recvRank,
                                          int batchSize)