Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
nits: self-review
Browse files Browse the repository at this point in the history
csegarragonz committed Feb 27, 2024
1 parent b3c3923 commit ea1a5c2
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions src/mpi/MpiWorld.cpp
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ MpiMessage MpiWorld::recvRemoteMpiMessage(int sendRank, int recvRank)
throw e;
}

// TODO: make sure we minimze copies here
// TODO(mpi-opt): make sure we minimze copies here
MpiMessage parsedMsg;
parseMpiMsg(msg, &parsedMsg);

Check warning on line 99 in src/mpi/MpiWorld.cpp

Codecov / codecov/patch

src/mpi/MpiWorld.cpp#L98-L99

Added lines #L98 - L99 were not covered by tests

@@ -1414,10 +1414,9 @@ void MpiWorld::probe(int sendRank, int recvRank, MPI_Status* status)
/*
const std::shared_ptr<InMemoryMpiQueue>& queue =
getLocalQueue(sendRank, recvRank);
// 30/12/21 - Peek will throw a runtime error
std::shared_ptr<MPIMessage> m = *(queue->peek());
// faabric_datatype_t* datatype = getFaabricDatatypeFromId(m->type());
faabric_datatype_t* datatype = getFaabricDatatypeFromId(m->type());
status->bytesSize = m->count() * datatype->size;
status->MPI_ERROR = 0;
status->MPI_SOURCE = m->sender();
@@ -1474,7 +1473,7 @@ void MpiWorld::initLocalQueues()
}
}

// TODO: double-check that the fast (no-async) path is fast
// TODO(mpi-opt): double-check that the fast (no-async) path is fast
MpiMessage MpiWorld::recvBatchReturnLast(int sendRank,
int recvRank,
int batchSize)

0 comments on commit ea1a5c2

Please sign in to comment.