planner(mpi): preload MPI SCALE_CHANGE decisions #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csegarragonz
force-pushed
the
mpi-preload
branch
from
4a6fab0 to
93a4560
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
- Coverage 82.05% 81.74% -0.31%
==========================================
Files 115 115
Lines 7628 7691 +63
==========================================
+ Hits 6259 6287 +28
- Misses 1369 1404 +35 ☔ View full report in Codecov by Sentry. |
csegarragonz
force-pushed
the
mpi-preload
branch
6 times, most recently
from
270627a to
b9da595
Compare
When scheduling a NEW app with the `ismpi` flag set, we know that this request will be quickly followed-up by a SCALE_CHANGE request with `worldSize` - 1 messages. As a consequence, and to guarantee optimal bin-packing on-par with Slurm, we can schedule `worldSize` messages when the first request arrives, dispatch just the first one, and preload the `worldSize` - 1 remaining.
csegarragonz
force-pushed
the
mpi-preload
branch
from
b9da595 to
ff4b44f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When scheduling a NEW app with the
ismpiflag set, we know that this request will be quickly followed-up by a SCALE_CHANGE request withworldSize- 1 messages. As a consequence, and to guarantee optimal bin-packing on-par with Slurm, we can scheduleworldSizemessages when the first request arrives, dispatch just the first one, and preload theworldSize- 1 remaining.