fix: improve user experience for build tool detector in import flow (#…

…564)
fabric8-launcher · Jan 16, 2019 · 09913d3 · 09913d3
1 parent 453cf69
commit 09913d3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.html b/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.html
@@ -94,7 +94,7 @@ <h3>Authorized Account Information</h3>
           <div class="col-xs-12" *ngIf="import">
             <div class="f8launcher-provider-card-detected-runtime" *ngIf="runtimeDetectionSecVisible">
               <h3>
-                Detected Runtime
+                {{ !isRuntimeDetected ? 'Detecting Runtime' : 'Detected Runtime' }}
               </h3>
               <div *ngIf="!isRuntimeDetected">
                 <i class="pficon pficon-in-progress fa-spin"></i>

diff --git a/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.spec.ts b/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.spec.ts
@@ -147,6 +147,7 @@ describe('GitProviderStepComponent', () => {
     const gitRepoDropdown = element.
       querySelector('#gitRt');
     expect(gitRepoDropdown.innerHTML).toContain('test');
+    component.isRuntimeDetected = true;
     expect(component.completed).toBe(true);
   });
   }));

diff --git a/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.ts b/projects/ngx-launcher/src/lib/components/gitprovider-step/gitprovider-step.component.ts
@@ -113,6 +113,9 @@ export class GitproviderStepComponent extends LauncherStep implements AfterViewI
    * @returns {boolean} True if step is completed
    */
   get completed(): boolean {
+    if (this.import) {
+      return this.form.valid && this.isRuntimeDetected;
+    }
     return this.form.valid;
   }