Remove redundant code and fix typo (#2329)

fabric8-services · Oct 25, 2018 · 44739f8 · 44739f8
1 parent 9879836
commit 44739f8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/controller/workitem.go b/controller/workitem.go
@@ -324,14 +324,6 @@ func findLastModified(wis []workitem.WorkItem) time.Time {
 // ConvertJSONAPIToWorkItem is responsible for converting given WorkItem model object into a
 // response resource object by jsonapi.org specifications
 func ConvertJSONAPIToWorkItem(ctx context.Context, method string, appl application.Application, source app.WorkItem, target *workitem.WorkItem, witID uuid.UUID, spaceID uuid.UUID) error {
-	// load work item type to perform conversion according to a field type
-	wit, err := appl.WorkItemTypes().Load(ctx, witID)
-	if err != nil {
-		return errs.Wrapf(err, "failed to load work item type: %s", witID)
-	}
-	_ = wit
-
-	// construct default values from input WI
 	version, err := getVersion(source.Attributes["version"])
 	if err != nil {
 		return err

diff --git a/migration/migration_blackbox_test.go b/migration/migration_blackbox_test.go
@@ -153,12 +153,12 @@ func TestMigrations(t *testing.T) {
 	t.Run("TestMigration101", testMigration101TypeGroupHasDescriptionField)
 	t.Run("TestMigration102", testMigration102LinkTypeDescriptionFields)
 	t.Run("TestMigration103", testMigration103NotNullNotEmptyonEmail)
-	t.Run("TestMirgraion104", testMigration104IndexOnWIRevisionTable)
-	t.Run("TestMirgraion105", testMigration105UpdateRootIterationAreaPathField)
-	t.Run("TestMirgraion106", testMigration106RemoveLinkCategoryConcept)
-	t.Run("TestMirgraion107", testMigration107NumberSequencesTable)
-	t.Run("TestMirgraion108", testMigration108NumberColumnForArea)
-	t.Run("TestMirgraion109", testMigration109NumberColumnForIteration)
+	t.Run("TestMigration104", testMigration104IndexOnWIRevisionTable)
+	t.Run("TestMigration105", testMigration105UpdateRootIterationAreaPathField)
+	t.Run("TestMigration106", testMigration106RemoveLinkCategoryConcept)
+	t.Run("TestMigration107", testMigration107NumberSequencesTable)
+	t.Run("TestMigration108", testMigration108NumberColumnForArea)
+	t.Run("TestMigration109", testMigration109NumberColumnForIteration)
 
 	// Perform the migration
 	err = migration.Migrate(sqlDB, databaseName)