fix(list-view): fix alignment of work item cells #2633

SMahil · 2018-05-11T06:48:25Z

Mandatory

What does this PR do?
fix alignments of work item cells
What issue/task does this PR references?
Difference in alignment of Label #2522
Are the tests Included?
NA
@mention(s) to expected reviewer(s) included
@rgarg1 @sanbornsen

centos-ci · 2018-05-14T06:50:46Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

rgarg1

The alignment issues are still seen in the list view, and as well as the quick-preview.

List view:

Quick-preview:

Note: Notice that other fields like Creator, Are, Iteration etc are also not aligned properly.

Another issue is observed with the Value-proposition WIT breaking the grid separation line:

SMahil · 2018-05-16T07:05:17Z

@rgarg1 In the table view, If labels are going in the second row they will get vertically aligned, not top aligned. In the quick preview, I will align them.

rgarg1 · 2018-05-18T09:00:17Z

@SMahil One test failed:

Work Item datatable list: should filter the workitem list by Assignee

Expected 17 to equal 0.

rgarg1 · 2018-05-18T09:10:44Z

Maybe this is yet not available in prod-preview: #2495

vikram-raj · 2018-05-18T12:55:19Z

[test]

nimishamukherjee · 2018-05-25T16:34:24Z

[test]

SMahil · 2018-05-28T04:11:19Z

[test]

SMahil · 2018-05-29T04:03:40Z

[test]

SMahil · 2018-05-29T09:31:17Z

[test]

SMahil · 2018-05-31T10:24:55Z

[test]

SMahil · 2018-06-05T11:37:13Z

[test]

Raunak1203 · 2018-06-07T06:55:39Z

src/app/components_ngrx/work-item-cell/work-item-cell.component.html

  <f8-assignee
    [showFullName]="false"
    [truncateAfter]="3"
-    [assignees]="row.assignees ? row.assignees : []"


@SMahil test is failing because of the space https://github.com/fabric8-ui/fabric8-planner/blob/master/src/tests/specs/workItemTableTest.spec.ts#L192
Could you please update test

tests spacing is fixed

centos-ci · 2018-06-08T07:56:04Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

vikram-raj · 2018-06-07T03:06:57Z

src/app/components_ngrx/work-item-cell/work-item-cell.component.less

@@ -15,4 +15,10 @@
 }
 .bold {
  font-weight: bold;
+}
+.assignees-cell {
+  .f8-assignees {


Where are you using this class?

.f8-assignees class will come from f8-assignee component which is required to have some styles overwritten here

centos-ci · 2018-06-13T14:30:29Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

Raunak1203 · 2018-06-19T10:26:44Z

[test]

Raunak1203

Thanks @SMahil
LGTM

centos-ci · 2018-07-02T07:08:07Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-04T12:25:53Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-04T15:22:50Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-09T09:35:23Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-09T11:34:41Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-09T16:45:30Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

centos-ci · 2018-07-10T12:17:58Z

@SMahil Your image is available in the registry. Run docker pull registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 registry.devshift.net/fabric8-ui/fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

nimishamukherjee · 2018-07-17T08:05:17Z

[test]

nimishamukherjee · 2018-07-17T10:45:29Z

[test]

centos-ci · 2018-07-31T09:50:05Z

@SMahil Your image is available in the registry. Run docker pull quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2633 && docker run -it -p 5000:8080 quay.io/openshiftio/rhel-fabric8-ui-fabric8-planner:SNAPSHOT-PR-2633 and visit http://localhost:5000 to access it.

* [WIP]fix(test) : update creator and link tests to run against prod-preview (#2725) * fix(test) : update creator and link tests to run against prod-preview * fix(test) : add selector for Plan, Board and Backlog Tab * fix(test) : fix script to run the tests against prod and prod-preview (#2726) * fix(tests) : Remove old JS based functional tests (#2732) * fix(tests) : Remove old JS based functional tests * Move google-chrome.repo file out of runtime/tests directory * Remove unnecessary package installation from Dockerfile (#2731) * fix(tests) : Added workitem-naughty-string-spec.ts and updated AgileTemplate spec (#2733) * feat(board): Board components added to planner * fix(actions): add action for BoardView * feat(card): add planner card component * fix(actions): add actions for to get Board api * fix(navigation): board side panel navigation added * feat(column): add column component * fix(effects): call boardApi in getBoards Effect * fix(board): add mapper in workitem and Board * fix(board): use action to update board * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): integrate board components with action, effects and model * fix(type): using proper type for side panel context * fix(board):add drag and drop * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): change structure of column component * fix(css): fix linter error for css * fix(board): get workitems for each column in board query * fix(columnWorkitem/board): use switchMap, add dafault to reducer switch case * fix(board-ngrx): Board State, Actions, Effects, Reducers (#2708) * fix(states): add BoardState to app.state * fix(actions): add action for BoardView * fix(actions): add actions for to get Board api * fix(common): add optional parameter to have different key in normalization * fix(reducersBoard): add reducers for BoardView * fix(effectsBoard): add effects for boardView * fix(effects): call boardApi in getBoards Effect * fix(common): add test for nprmalize array * fix(board): add mapper in workitem and Board * fix(column-workitem): add state for column-workitem * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): add default for column workItem reducer * fix(columnWorkitem): add unit test for default case * fix(card): add assignee component * fix(board): preparing board model to fetch work items * fix(board): fetch work item for board * fix(board): fetch work item bug fixed * fix(board): send patch and reorder requests * fix(board): initialize column on updateSuccess if not created * fix(tests): unit test for column workItem reducer * fix(workItem): fix workItemMapper test * fix(board): use array instead of set, update unit tests * fix(board): send array of column ids in column workitem Update action * fix(column-workitem): handled column update fail * fix(board): add quick preview to board view * fix(workitem-effect): unnecessary code is removed for column change * fix(board): add unit test for columnWorkitem actions and reduces * fix(board): board ui state added with board lockdown feature * fix(quick-preview): add condition to check if request coming from board or list * fix(quick preview): add context input to correctly redirect to detail page route * fix(card): fix child iteration name * fix(board): fix 404 error on redirect to profile * fix(customQuery): add modal component to board for custom query delete * fix(board): disable drag n drop for non-collaborators * fix(board): change username to full name * fix(field): meta state field is removed from the detail page * fix(board): add board view For iterations * fix(card): fix workitem type icon * fix(grouptype): select the default group type on load * fix(workItemUtil): check if query is present in current route or not * fix(package-lock): update package-lock.json * fix(test): Upgrade pip version - Add python-devel to dependencies * fix(list-view): fix alignment of work item cells (#2633) * fix(list-view): fix alignment of work item cells * fix(labels): fix label alignment in quick preview * fix(tests): fix tests spacing * fix(test): fix tests * fix(labels): fix labels in comments and assignee cell width * fix(datatable): update cookie version for datatable * fix(datatable): fix width of overflown work item cells * fix(comment): add button type * fix(labels): fix scpacing between labels * fix(wi-cell): fix width for iteration/labels and tooltip for iteration * fix(tests): fix test for iteration title length * fix(test) : fix failing label test

* fix(list-view): fix alignment of work item cells * fix(labels): fix label alignment in quick preview * fix(tests): fix tests spacing * fix(test): fix tests * fix(labels): fix labels in comments and assignee cell width * fix(datatable): update cookie version for datatable * fix(datatable): fix width of overflown work item cells * fix(comment): add button type * fix(labels): fix scpacing between labels * fix(wi-cell): fix width for iteration/labels and tooltip for iteration * fix(tests): fix test for iteration title length

* feat(board): Board components added to planner * fix(actions): add action for BoardView * feat(card): add planner card component * fix(actions): add actions for to get Board api * fix(navigation): board side panel navigation added * feat(column): add column component * fix(effects): call boardApi in getBoards Effect * fix(board): add mapper in workitem and Board * fix(board): use action to update board * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): integrate board components with action, effects and model * fix(type): using proper type for side panel context * fix(board):add drag and drop * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): change structure of column component * fix(css): fix linter error for css * fix(board): get workitems for each column in board query * fix(columnWorkitem/board): use switchMap, add dafault to reducer switch case * fix(board-ngrx): Board State, Actions, Effects, Reducers (#2708) * fix(states): add BoardState to app.state * fix(actions): add action for BoardView * fix(actions): add actions for to get Board api * fix(common): add optional parameter to have different key in normalization * fix(reducersBoard): add reducers for BoardView * fix(effectsBoard): add effects for boardView * fix(effects): call boardApi in getBoards Effect * fix(common): add test for nprmalize array * fix(board): add mapper in workitem and Board * fix(column-workitem): add state for column-workitem * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): add default for column workItem reducer * fix(columnWorkitem): add unit test for default case * fix(card): add assignee component * fix(board): preparing board model to fetch work items * fix(board): fetch work item for board * fix(board): fetch work item bug fixed * fix(board): send patch and reorder requests * fix(board): initialize column on updateSuccess if not created * fix(tests): unit test for column workItem reducer * fix(workItem): fix workItemMapper test * fix(board): use array instead of set, update unit tests * fix(board): send array of column ids in column workitem Update action * fix(column-workitem): handled column update fail * fix(board): add quick preview to board view * fix(workitem-effect): unnecessary code is removed for column change * fix(board): add unit test for columnWorkitem actions and reduces * fix(board): board ui state added with board lockdown feature * fix(quick-preview): add condition to check if request coming from board or list * fix(quick preview): add context input to correctly redirect to detail page route * fix(card): fix child iteration name * fix(board): fix 404 error on redirect to profile * fix(customQuery): add modal component to board for custom query delete * fix(board): disable drag n drop for non-collaborators * fix(board): change username to full name * fix(field): meta state field is removed from the detail page * fix(board): add board view For iterations * fix(card): fix workitem type icon * fix(grouptype): select the default group type on load * fix(workItemUtil): check if query is present in current route or not * fix(package-lock): update package-lock.json * fix(test): Upgrade pip version - Add python-devel to dependencies * fix(list-view): fix alignment of work item cells (#2633) * fix(list-view): fix alignment of work item cells * fix(labels): fix label alignment in quick preview * fix(tests): fix tests spacing * fix(test): fix tests * fix(labels): fix labels in comments and assignee cell width * fix(datatable): update cookie version for datatable * fix(datatable): fix width of overflown work item cells * fix(comment): add button type * fix(labels): fix scpacing between labels * fix(wi-cell): fix width for iteration/labels and tooltip for iteration * fix(tests): fix test for iteration title length * feat(query-tab): Added basic query module with routing. * fix(test) : fix failing label test (#2741) This PR fixes the failing label test due to changes in the API tests PR fabric8io/fabric8-test#911 * fix(list): by default remove Closed work item from list. (#2743) * fix(list): by default remove Closed work item from list. * fix(test): add functional test * fix order of child-types in work-item type dropdown test * add feature-flag on query-module * Revert "add feature-flag on query-module" This reverts commit 53a9e28. * fix(events): oldValue or newValue not present return empty array * fix(events): add unit test for failing events * fix(events): add unit test for attributes newValue and oldValue * fix(events): handle the case of list values in data.attribute * feat(query): add feature-flag on query-module (#2750) * fix(test): Change spec timeout from 60 mins to 3 mins (#2752) * fix(query): fix provider dependencies for local env using feature-flag * fix(test): fixed workItemTable tests and added change wi type test * fix(table-config): add table-config component * fix(list): add table-config to planner- list * fix(work-item-cell): create a module for work-cell-component * fix(columnFilterPipe): add module.ts for column filter * fix(urlQuery): remove space id form query * fix(effects-query): add space query before sending the search api request * fix(query): add table and input to query language * fix(query): add reset workitem action * fix(quick-preview): ouput full workItem from work-item-cell to open quick preview * fix(query-input): add clear button to clear the input * fix(query): add ctrl+backspace to clear the query * feat(change-wi-type): implement new design for change-wi-type * fix(test): fix dropdown tests * fix(query): fix input field * fix(WorkItemType): WorkItemType Normalization and WorkItem Detail Component refactor * fix(workItem): create a action and effect to get children for query page * fix(query): add child exploration and breadcrumbs * fix(plannerList): use spaceQuery to get the spaceSource * feat(change-wi-type): add necessary changes after WIT normalization * fix(query): align explore children css and breadcrumbs css * fix(filter-service); add support of $OR query length===1 in getConditionFromQuery * fix(tests): change the class for settings dropdown and detail page icon * fix(tests): use new table-config class * fix(WorkItemutils): add spaceId befire sending the request in workitemMatchesFilter * fix(common-dropdown): icon support added * fix(detail): type and state using common dropdown * fix(detailPage): fix View full detail link from quick Preview * fix(query): fetch workItems after workItemTypes are loaded * fix(workItemUtil): add a condition for query page in workItem util * fix(test): fix type and state drop-down tests * fix(boardUIQuery): add a filter on boardLocked * fix(test): fixed test for disabled state dropdown * fix(WorkITemLinks): add condition for query context to open detail page from link section * fix(query): fix css for clear button in input * fix(PlannerList): only send workItemId and children Link to fetch the children * fix(test): create new item for type change test * fix(wi-title): fix title overflow and align cell items center (#2759) * fix(CI): Push PR Snapshot images to quay.io instead of devshift (#2762)

* feat(board): Board components added to planner * fix(actions): add action for BoardView * feat(card): add planner card component * fix(actions): add actions for to get Board api * fix(navigation): board side panel navigation added * feat(column): add column component * fix(effects): call boardApi in getBoards Effect * fix(board): add mapper in workitem and Board * fix(board): use action to update board * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): integrate board components with action, effects and model * fix(type): using proper type for side panel context * fix(board):add drag and drop * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): change structure of column component * fix(css): fix linter error for css * fix(board): get workitems for each column in board query * fix(columnWorkitem/board): use switchMap, add dafault to reducer switch case * fix(board-ngrx): Board State, Actions, Effects, Reducers (fabric8-ui#2708) * fix(states): add BoardState to app.state * fix(actions): add action for BoardView * fix(actions): add actions for to get Board api * fix(common): add optional parameter to have different key in normalization * fix(reducersBoard): add reducers for BoardView * fix(effectsBoard): add effects for boardView * fix(effects): call boardApi in getBoards Effect * fix(common): add test for nprmalize array * fix(board): add mapper in workitem and Board * fix(column-workitem): add state for column-workitem * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): add default for column workItem reducer * fix(columnWorkitem): add unit test for default case * fix(card): add assignee component * fix(board): preparing board model to fetch work items * fix(board): fetch work item for board * fix(board): fetch work item bug fixed * fix(board): send patch and reorder requests * fix(board): initialize column on updateSuccess if not created * fix(tests): unit test for column workItem reducer * fix(workItem): fix workItemMapper test * fix(board): use array instead of set, update unit tests * fix(board): send array of column ids in column workitem Update action * fix(column-workitem): handled column update fail * fix(board): add quick preview to board view * fix(workitem-effect): unnecessary code is removed for column change * fix(board): add unit test for columnWorkitem actions and reduces * fix(board): board ui state added with board lockdown feature * fix(quick-preview): add condition to check if request coming from board or list * fix(quick preview): add context input to correctly redirect to detail page route * fix(card): fix child iteration name * fix(board): fix 404 error on redirect to profile * fix(customQuery): add modal component to board for custom query delete * fix(board): disable drag n drop for non-collaborators * fix(board): change username to full name * fix(field): meta state field is removed from the detail page * fix(board): add board view For iterations * fix(card): fix workitem type icon * fix(grouptype): select the default group type on load * fix(workItemUtil): check if query is present in current route or not * fix(package-lock): update package-lock.json * fix(test): Upgrade pip version - Add python-devel to dependencies * fix(list-view): fix alignment of work item cells (fabric8-ui#2633) * fix(list-view): fix alignment of work item cells * fix(labels): fix label alignment in quick preview * fix(tests): fix tests spacing * fix(test): fix tests * fix(labels): fix labels in comments and assignee cell width * fix(datatable): update cookie version for datatable * fix(datatable): fix width of overflown work item cells * fix(comment): add button type * fix(labels): fix scpacing between labels * fix(wi-cell): fix width for iteration/labels and tooltip for iteration * fix(tests): fix test for iteration title length * feat(query-tab): Added basic query module with routing. * fix(test) : fix failing label test (fabric8-ui#2741) This PR fixes the failing label test due to changes in the API tests PR fabric8io/fabric8-test#911 * fix(list): by default remove Closed work item from list. (fabric8-ui#2743) * fix(list): by default remove Closed work item from list. * fix(test): add functional test * fix order of child-types in work-item type dropdown test * add feature-flag on query-module * Revert "add feature-flag on query-module" This reverts commit 53a9e28. * fix(events): oldValue or newValue not present return empty array * fix(events): add unit test for failing events * fix(events): add unit test for attributes newValue and oldValue * fix(events): handle the case of list values in data.attribute * feat(query): add feature-flag on query-module (fabric8-ui#2750) * fix(test): Change spec timeout from 60 mins to 3 mins (fabric8-ui#2752) * fix(query): fix provider dependencies for local env using feature-flag * fix(test): fixed workItemTable tests and added change wi type test * fix(table-config): add table-config component * fix(list): add table-config to planner- list * fix(work-item-cell): create a module for work-cell-component * fix(columnFilterPipe): add module.ts for column filter * fix(urlQuery): remove space id form query * fix(effects-query): add space query before sending the search api request * fix(query): add table and input to query language * fix(query): add reset workitem action * fix(quick-preview): ouput full workItem from work-item-cell to open quick preview * fix(query-input): add clear button to clear the input * fix(query): add ctrl+backspace to clear the query * feat(change-wi-type): implement new design for change-wi-type * fix(test): fix dropdown tests * fix(query): fix input field * fix(WorkItemType): WorkItemType Normalization and WorkItem Detail Component refactor * fix(workItem): create a action and effect to get children for query page * fix(query): add child exploration and breadcrumbs * fix(plannerList): use spaceQuery to get the spaceSource * feat(change-wi-type): add necessary changes after WIT normalization * fix(query): align explore children css and breadcrumbs css * fix(filter-service); add support of $OR query length===1 in getConditionFromQuery * fix(tests): change the class for settings dropdown and detail page icon * fix(tests): use new table-config class * fix(WorkItemutils): add spaceId befire sending the request in workitemMatchesFilter * fix(common-dropdown): icon support added * fix(detail): type and state using common dropdown * fix(detailPage): fix View full detail link from quick Preview * fix(query): fetch workItems after workItemTypes are loaded * fix(workItemUtil): add a condition for query page in workItem util * fix(test): fix type and state drop-down tests * fix(boardUIQuery): add a filter on boardLocked * fix(test): fixed test for disabled state dropdown * fix(WorkITemLinks): add condition for query context to open detail page from link section * fix(query): fix css for clear button in input * fix(PlannerList): only send workItemId and children Link to fetch the children * fix(test): create new item for type change test * fix(wi-title): fix title overflow and align cell items center (fabric8-ui#2759) * fix(CI): Push PR Snapshot images to quay.io instead of devshift (fabric8-ui#2762)

@deprecated

* [WIP]fix(test) : update creator and link tests to run against prod-preview (#2725) * fix(test) : update creator and link tests to run against prod-preview * fix(test) : add selector for Plan, Board and Backlog Tab * fix(test) : fix script to run the tests against prod and prod-preview (#2726) * fix(tests) : Remove old JS based functional tests (#2732) * fix(tests) : Remove old JS based functional tests * Move google-chrome.repo file out of runtime/tests directory * Remove unnecessary package installation from Dockerfile (#2731) * fix(tests) : Added workitem-naughty-string-spec.ts and updated AgileTemplate spec (#2733) * feat(board): Board components added to planner * fix(actions): add action for BoardView * feat(card): add planner card component * fix(actions): add actions for to get Board api * fix(navigation): board side panel navigation added * feat(column): add column component * fix(effects): call boardApi in getBoards Effect * fix(board): add mapper in workitem and Board * fix(board): use action to update board * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): integrate board components with action, effects and model * fix(type): using proper type for side panel context * fix(board):add drag and drop * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): change structure of column component * fix(css): fix linter error for css * fix(board): get workitems for each column in board query * fix(columnWorkitem/board): use switchMap, add dafault to reducer switch case * fix(board-ngrx): Board State, Actions, Effects, Reducers (#2708) * fix(states): add BoardState to app.state * fix(actions): add action for BoardView * fix(actions): add actions for to get Board api * fix(common): add optional parameter to have different key in normalization * fix(reducersBoard): add reducers for BoardView * fix(effectsBoard): add effects for boardView * fix(effects): call boardApi in getBoards Effect * fix(common): add test for nprmalize array * fix(board): add mapper in workitem and Board * fix(column-workitem): add state for column-workitem * fix(board): add reducer for boardColumn * fix(board): add states and reducer to board module * fix(board): add column-workItem reducer * fix(board): fix tests for board service, reducer, model * fix(reducer): add unit test for column-workitem reducer * fix(board): remove board-api-url action from boardAction * fix(workitem): add getWorkItemWithIds query to WorItemQuery * fix(board): assign value in board effects, change type of columnIds, fix unit tests, fix column-workItem reducer * fix(board): add default for column workItem reducer * fix(columnWorkitem): add unit test for default case * fix(card): add assignee component * fix(board): preparing board model to fetch work items * fix(board): fetch work item for board * fix(board): fetch work item bug fixed * fix(board): send patch and reorder requests * fix(board): initialize column on updateSuccess if not created * fix(tests): unit test for column workItem reducer * fix(workItem): fix workItemMapper test * fix(board): use array instead of set, update unit tests * fix(board): send array of column ids in column workitem Update action * fix(column-workitem): handled column update fail * fix(board): add quick preview to board view * fix(workitem-effect): unnecessary code is removed for column change * fix(board): add unit test for columnWorkitem actions and reduces * fix(board): board ui state added with board lockdown feature * fix(quick-preview): add condition to check if request coming from board or list * fix(quick preview): add context input to correctly redirect to detail page route * fix(card): fix child iteration name * fix(board): fix 404 error on redirect to profile * fix(customQuery): add modal component to board for custom query delete * fix(board): disable drag n drop for non-collaborators * fix(board): change username to full name * fix(field): meta state field is removed from the detail page * fix(board): add board view For iterations * fix(card): fix workitem type icon * fix(grouptype): select the default group type on load * fix(workItemUtil): check if query is present in current route or not * fix(package-lock): update package-lock.json * fix(test): Upgrade pip version - Add python-devel to dependencies * fix(list-view): fix alignment of work item cells (#2633) * fix(list-view): fix alignment of work item cells * fix(labels): fix label alignment in quick preview * fix(tests): fix tests spacing * fix(test): fix tests * fix(labels): fix labels in comments and assignee cell width * fix(datatable): update cookie version for datatable * fix(datatable): fix width of overflown work item cells * fix(comment): add button type * fix(labels): fix scpacing between labels * fix(wi-cell): fix width for iteration/labels and tooltip for iteration * fix(tests): fix test for iteration title length * fix(test) : fix failing label test (#2741) This PR fixes the failing label test due to changes in the API tests PR fabric8io/fabric8-test#911 * fix(list): by default remove Closed work item from list. (#2743) * fix(list): by default remove Closed work item from list. * fix(test): add functional test * feat(query-tab): Added basic query module with routing. * fix order of child-types in work-item type dropdown test * add feature-flag on query-module * Revert "add feature-flag on query-module" This reverts commit 53a9e28. * feat(query): add feature-flag on query-module (#2750) * fix(test): Change spec timeout from 60 mins to 3 mins (#2752) * fix(events): oldValue or newValue not present return empty array * fix(events): add unit test for failing events * fix(events): add unit test for attributes newValue and oldValue * fix(events): handle the case of list values in data.attribute * fix(query): fix provider dependencies for local env using feature-flag * fix(WorkItemType): WorkItemType Normalization and WorkItem Detail Component refactor * fix(plannerList): use spaceQuery to get the spaceSource * fix(table-config): add table-config component * fix(list): add table-config to planner- list * fix(work-item-cell): create a module for work-cell-component * fix(columnFilterPipe): add module.ts for column filter * fix(urlQuery): remove space id form query * fix(effects-query): add space query before sending the search api request * fix(query): add table and input to query language * fix(query): add reset workitem action * fix(quick-preview): ouput full workItem from work-item-cell to open quick preview * fix(query-input): add clear button to clear the input * fix(query): add ctrl+backspace to clear the query * fix(query): fix input field * fix(workItem): create a action and effect to get children for query page * fix(query): add child exploration and breadcrumbs * fix(query): align explore children css and breadcrumbs css * fix(filter-service); add support of $OR query length===1 in getConditionFromQuery * fix(tests): change the class for settings dropdown and detail page icon * fix(tests): use new table-config class * fix(WorkItemutils): add spaceId befire sending the request in workitemMatchesFilter * fix(detailPage): fix View full detail link from quick Preview * fix(query): fetch workItems after workItemTypes are loaded * fix(workItemUtil): add a condition for query page in workItem util * fix(boardUIQuery): add a filter on boardLocked * fix(WorkITemLinks): add condition for query context to open detail page from link section * fix(query): fix css for clear button in input * fix(PlannerList): only send workItemId and children Link to fetch the children * fix(test): fixed workItemTable tests and added change wi type test * feat(change-wi-type): implement new design for change-wi-type * fix(test): fix dropdown tests * feat(change-wi-type): add necessary changes after WIT normalization * fix(common-dropdown): icon support added * fix(detail): type and state using common dropdown * fix(test): fix type and state drop-down tests * fix(test): fixed test for disabled state dropdown * fix(test): create new item for type change test * fix(wi-title): fix title overflow and align cell items center (#2759) * fix(CI): Push PR Snapshot images to quay.io instead of devshift (#2762) * fix(tests) : Update UI tests to run on both Agile and SDD template parallelly (#2747) * fix(workItemCell): fix titile truncate for query page * fix(workitem-service): legacy codes are removed from this service - Most of the unused, legacy codes are removed from this service - Some of the legacy methods are still being used in fabrc8-ui - They are marked as JSDoc @deprecated - Deprecated preperties will be removed soon * fix(test): added tests for work item service * fix(clean-up): removed space observable dependency from main methods - `this._currentSpace` dependency is removed from all the main methods * fix(tests): more unit tests for work item service * fix(package): filter service is exported for planner consumers * fix(effects): fixed wi effects based on the changes in services * fix(service): fixed link url for wi ser * fix(ngrx): listening to user change just once for the list load * fix(link-type): query for link-type added and used - get linkTypes action dispatches in space effects now * fix(links): initial state for work item link is made null - null means not fetched yet - a new action to reset the state is added * feat(ng-let): ng-let directive added for async convenience * fix(link-query): link and link-type querries are added * fix(selector): selector components refactored * fix(selector): optional on select close feature added to common dropdown * feat(typeahead): new typeahead component created on top of base selector * fix(ng-let): module added for ngLet * fix(selector): fixing on open event for type ahead selector * fix(less): fixed the border issue in detail page tabs * fix(link): link reducer to return new state on error to update DOM * feat(link-component): work item link component refactorred - Use of async pipe - Use of new type ahead search - New link creation experience * fix(selector): search loader added to the type ahead selector * fix(link-search): create link on empty work item save button handled * fix(style): style updated for selector dropdowns * fix(link): empty link creator section removed * fix(code): removed old type ahead component * fix(selector): truncate in selector is made as input * fix(typeahead): display value removed from the item structure * fix(dropdown): description for dropdown is added * fix(test): fixed functional test for new dropdown component * fix(link-type): link type descriptions added * fix(test): added unit tests for type ahead selector component * fix(link): newly added links are highlighted * fix(link): fixed the CSS alignment for link list * fix(test): state and type dropdown test fixed * fix(link): fixed linking bugs in the link section * fix(datatable): make tree view indentation 20px * fix(quick-preview): Remove mouse cursor for current assignees on a work item (#2763) * add http-service.spec.ts * chore(event): remove unused imports * fix(planner-list): add HttpClientModule and HTTP_INTERCEPTORS to planner-list module * fix(http.service): use HttpClient service in collaborators - use AuthInterceptor for AuthorizationToken - create get method for HttpClient * fix(httpService): use HttpBackendClient to send request * fix(interceptor): create interceptor specific to auth header * fix(httpclient): add http-module and interceptors * fix(workItemsService): use httpclient in workItemService to send request for create comment * fix(httpclien): use HttpBackend to resolve redirection problem in firefox * fix(httpclient): add httpClient for area and booard service * fix(custom-query-service): new httpClient implemented * fix(grouptype-service): replaced http service with new http client * fix(infotip-service): info tip service upgraded with new http client * fix(workItemService): add HttpClient for workItemService * fix(tests): unit tests for board and collaborator service * fix(iteration-service): iteration service refactored with httpClient * fix(label-service): label service refactored with http client * fix(refactor): unwanted services are removed * fix(unit-tests): fix test for board. collaborator and workitem service * fix(workItemService): refactor workitem service * fix(service): refactor link-type, custom-query, httpService * fix(httpService): remove http service and code related to it * fix(test): added test for new http service * fix(filterService): add HttpClient to filterService, fix unit tests * fix(httpservice): use responseType:'text' for delete requests * fix(test): fixed unit test for body less DELETE response * fix(tests): reorganize imports in http service spec * fix(event): non-collab user issue in event is fixed

SMahil requested review from sanbornsen and rgarg1 May 11, 2018 06:48

SMahil mentioned this pull request May 11, 2018

Difference in alignment of Label #2522

Open

SMahil added the Ready for review label May 11, 2018

rgarg1 suggested changes May 16, 2018

View reviewed changes

rgarg1 removed the Ready for review label May 16, 2018

SMahil added the Ready for review label May 18, 2018

SMahil force-pushed the issue-2522 branch from 5f9f52e to f08c0a3 Compare May 18, 2018 09:57

rgarg1 removed the Ready for review label May 23, 2018

SMahil force-pushed the issue-2522 branch from 9f5d431 to 09b093b Compare May 29, 2018 10:54

SMahil force-pushed the issue-2522 branch from 930bc24 to 343d661 Compare June 6, 2018 09:34

Raunak1203 previously requested changes Jun 7, 2018

View reviewed changes

SMahil force-pushed the issue-2522 branch from 343d661 to 9aaafd5 Compare June 7, 2018 10:12

vikram-raj reviewed Jun 13, 2018

View reviewed changes

SMahil force-pushed the issue-2522 branch from e9078d1 to 29afa91 Compare June 19, 2018 09:08

Raunak1203 approved these changes Jul 2, 2018

View reviewed changes

SMahil force-pushed the issue-2522 branch from 4de1ab8 to 60d8dfd Compare July 12, 2018 09:59

SMahil added 11 commits July 31, 2018 21:24

fix(list-view): fix alignment of work item cells

6b09f51

fix(labels): fix label alignment in quick preview

464aa6a

fix(tests): fix tests spacing

93d3971

fix(test): fix tests

1a7d872

fix(labels): fix labels in comments and assignee cell width

66c4b52

fix(datatable): update cookie version for datatable

4956c4a

fix(datatable): fix width of overflown work item cells

a1e6802

fix(comment): add button type

4648b75

fix(labels): fix scpacing between labels

5dd645c

fix(wi-cell): fix width for iteration/labels and tooltip for iteration

a964228

fix(tests): fix test for iteration title length

02872f0

SMahil force-pushed the issue-2522 branch from f96edc2 to 02872f0 Compare July 31, 2018 09:27

nimishamukherjee merged commit 17598a9 into fabric8-ui:master Jul 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(list-view): fix alignment of work item cells #2633

fix(list-view): fix alignment of work item cells #2633

SMahil commented May 11, 2018 •

edited by rgarg1

Loading

centos-ci commented May 14, 2018

rgarg1 left a comment •

edited

Loading

SMahil commented May 16, 2018

rgarg1 commented May 18, 2018 •

edited

Loading

rgarg1 commented May 18, 2018

vikram-raj commented May 18, 2018

nimishamukherjee commented May 25, 2018

SMahil commented May 28, 2018

SMahil commented May 29, 2018

SMahil commented May 29, 2018

SMahil commented May 31, 2018

SMahil commented Jun 5, 2018

Raunak1203 Jun 7, 2018

centos-ci commented Jun 8, 2018

vikram-raj Jun 7, 2018

SMahil Jun 13, 2018

centos-ci commented Jun 13, 2018

Raunak1203 commented Jun 19, 2018

Raunak1203 left a comment

centos-ci commented Jul 2, 2018

centos-ci commented Jul 4, 2018

centos-ci commented Jul 4, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 10, 2018

nimishamukherjee commented Jul 17, 2018

nimishamukherjee commented Jul 17, 2018

centos-ci commented Jul 31, 2018

fix(list-view): fix alignment of work item cells #2633

fix(list-view): fix alignment of work item cells #2633

Conversation

SMahil commented May 11, 2018 • edited by rgarg1 Loading

Mandatory

centos-ci commented May 14, 2018

rgarg1 left a comment • edited Loading

Choose a reason for hiding this comment

SMahil commented May 16, 2018

rgarg1 commented May 18, 2018 • edited Loading

rgarg1 commented May 18, 2018

vikram-raj commented May 18, 2018

nimishamukherjee commented May 25, 2018

SMahil commented May 28, 2018

SMahil commented May 29, 2018

SMahil commented May 29, 2018

SMahil commented May 31, 2018

SMahil commented Jun 5, 2018

Raunak1203 Jun 7, 2018

Choose a reason for hiding this comment

centos-ci commented Jun 8, 2018

vikram-raj Jun 7, 2018

Choose a reason for hiding this comment

SMahil Jun 13, 2018

Choose a reason for hiding this comment

centos-ci commented Jun 13, 2018

Raunak1203 commented Jun 19, 2018

Raunak1203 left a comment

Choose a reason for hiding this comment

centos-ci commented Jul 2, 2018

centos-ci commented Jul 4, 2018

centos-ci commented Jul 4, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 9, 2018

centos-ci commented Jul 10, 2018

nimishamukherjee commented Jul 17, 2018

nimishamukherjee commented Jul 17, 2018

centos-ci commented Jul 31, 2018

SMahil commented May 11, 2018 •

edited by rgarg1

Loading

rgarg1 left a comment •

edited

Loading

rgarg1 commented May 18, 2018 •

edited

Loading