Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for --cacheFrom and --cacheTo buildX arguments #1730

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

orange-buffalo
Copy link
Contributor

Closes #1621

@orange-buffalo orange-buffalo marked this pull request as ready for review November 30, 2023 06:51
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #1730 (30de2d6) into master (1b4dec5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1730      +/-   ##
============================================
+ Coverage     65.25%   65.31%   +0.06%     
- Complexity     2276     2280       +4     
============================================
  Files           172      172              
  Lines         10165    10184      +19     
  Branches       1401     1405       +4     
============================================
+ Hits           6633     6652      +19     
  Misses         2983     2983              
  Partials        549      549              
Files Coverage Δ
...bric8/maven/docker/config/BuildXConfiguration.java 97.82% <100.00%> (+0.60%) ⬆️
...aven/docker/config/handler/property/ConfigKey.java 100.00% <100.00%> (ø)
...config/handler/property/PropertyConfigHandler.java 86.17% <100.00%> (+0.08%) ⬆️
...io/fabric8/maven/docker/service/BuildXService.java 76.63% <100.00%> (+0.65%) ⬆️

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@rohanKanojia
Copy link
Member

Thanks a lot for your PR! I just have a minor comment otherwise it looks good.

@rohanKanojia rohanKanojia merged commit c5cc4db into fabric8io:master Dec 3, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildx cache-from / cache-to
2 participants