Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : AuthConfigList is populated with from images during buildx push as well #1751

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rohanKanojia
Copy link
Member

Description

Fix #1709

  • During BuildX push we also need credentials for pulling base images used in Dockerfile. Sending a single AuthConfig just for push registry will not work.
  • Refactor code in BuildMojo to extract AuthConfig for base images used in Build configuration / Dockerfile . Move common logic as static methods in RegistryService so that it can be reused in both build and push goals.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Merging #1751 (4935994) into master (f58346e) will increase coverage by 0.02%.
The diff coverage is 89.58%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1751      +/-   ##
============================================
+ Coverage     65.73%   65.76%   +0.02%     
- Complexity     2290     2294       +4     
============================================
  Files           172      172              
  Lines         10184    10184              
  Branches       1405     1405              
============================================
+ Hits           6694     6697       +3     
+ Misses         2936     2934       -2     
+ Partials        554      553       -1     
Files Coverage Δ
...fabric8/maven/docker/AbstractBuildSupportMojo.java 100.00% <ø> (ø)
...va/io/fabric8/maven/docker/AbstractDockerMojo.java 58.89% <100.00%> (+0.25%) ⬆️
...c/main/java/io/fabric8/maven/docker/BuildMojo.java 34.52% <100.00%> (-16.27%) ⬇️
...rc/main/java/io/fabric8/maven/docker/PushMojo.java 53.84% <100.00%> (ø)
.../fabric8/maven/docker/service/RegistryService.java 83.20% <88.88%> (+2.47%) ⬆️

... and 1 file with indirect coverage changes

Copy link

@rohanKanojia rohanKanojia marked this pull request as ready for review February 12, 2024 04:52
@rohanKanojia rohanKanojia merged commit 40371e7 into fabric8io:master Feb 12, 2024
20 checks passed
@rohanKanojia rohanKanojia deleted the pr/issue1709 branch February 12, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Architecture Builds Succeed But Fail to Push
1 participant