Fix: Changed statement like while to enhanced for loop and if to ternary operator
#1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1757 +/- ##
============================================
- Coverage 65.76% 65.74% -0.02%
Complexity 2294 2294
============================================
Files 172 172
Lines 10184 10181 -3
Branches 1405 1405
============================================
- Hits 6697 6693 -4
- Misses 2934 2935 +1
Partials 553 553
|
src/main/java/io/fabric8/maven/docker/model/ContainerDetails.java
Outdated
Show resolved
Hide resolved
src/main/java/io/fabric8/maven/docker/model/ContainersListElement.java
Outdated
Show resolved
Hide resolved
mdxabu
changed the title
if to ternary operatorif to ternary operator
src/main/java/io/fabric8/maven/docker/model/ContainerDetails.java
Outdated
Show resolved
Hide resolved
… and Removed the if statement and replace with ternary statement in ContainerDetails.java Signed-off-by: M. <[email protected]> Co-Authored-By: Rohan Kumar <[email protected]>
|
rohanKanojia
approved these changes
Feb 22, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Maintainers,
I wanted to inform you that I have made some modifications in two files:
ContainersListElements.javaandContainerDetails.java. Specifically, I have changed thewhileloop to anenhanced forloop and altered theifstatement to aternarystatement.Best regards,
F Mohamed Abdullah