fix: support skipping tags #1787
Conversation
src/main/java/io/fabric8/maven/docker/config/BuildImageConfiguration.java
Show resolved
Hide resolved
nodece
force-pushed
the
buildx-skip-tag
branch
2 times, most recently
from
a3dc832 to
7dcc06f
Compare
|
@rohanKanojia Thank you for your review, this PR has been updated, could you review this PR again? |
|
MacOS ci failed, what do you suggest, it seems to be unable to pull pg image. |
|
@nodece : Could you please address Sonar Code smells that seem applicable? |
|
@rohanKanojia Done. |
|
should I upgrade the postgres image? It looks blocked my PR. |
|
@nodece : Could you please rebase this one? |
| @Test | ||
| void buildWithSkipTag() throws IOException, MojoExecutionException { | ||
| buildWithTag(true); | ||
| } |
There was a problem hiding this comment.
Is it possible to somehow use @Nested annotation to group normal build and buildX tests? Initially, I was a bit confused by the test names. Can we use JUnit5 parameterized tests here to reduce duplication?
|
|
@nodece : Thanks, looks good to be merged. Only thing I see missing is documentation. Could you please add documentation for this new field Could you also add an entry for this change in doc/changelog.md? |
Please see the PR description, I can also add the more description about when tag the image.
I can add skipTag parameter description to the changlong. |
|
You're right. Documentation is already there for plugin configuration |
The skipTag parameter exists in the plugin configuration and image levels(docker:build), could you check this documentation? Please see https://dmp.fabric8.io/#build-configuration |
|
@nodece : oh, that's quite strange. I see that this field got added in this PR. |
|
The documentation was wrongly added in #954 |
Motivation
I'm using the buildx to build the multiple-arch images, when I use
-Ddocker.skip.tag=trueto skip the tag, this plugin still tags the image.Changes
<skipTag>true, the plugin will not tag the image on the build and buildx stageDoc
The previous document included
<skipTag>, so I did not add the document.