Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of Plexus DI and more #1851

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cstamas
Copy link
Contributor

@cstamas cstamas commented Jan 3, 2025

Main goal: get rid of archaic Plexus DI and Plexus Container related stuff. As a side effect, drop usage of maven-shared-utils (wherever possible, only MessageUtils should be used from it for now), use plexus-utils (p-u 4.x + p-xml 3.x for Maven 3 compatibility) instead. Finally, apply some mild updates to dependencies and plugins.

Changes:

  • drop Plexus DI (only remnant now is components.xml with lifecycle mapping)
  • drop/switch from maven-shared-utils to plexus-utils
  • update m-assembly-p to latest
  • updates some other deps, align them

The remaining components.xml can be replaced as explained here: https://cstamas.org/blog/2024/09/add-new-maven-lifecycle/

Locally built (w/ ITs) using latest Maven 4 (master: 1f157ad60161890d6c3b71d4be374ad026385c60) and is OK

@cstamas cstamas marked this pull request as ready for review January 3, 2025 21:43
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
57.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant