This repository has been archived by the owner on Nov 6, 2018. It is now read-only.
Fix for #338 #344
Merged
Fix for #338 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[merge] |
|
CI needs that fancy merge comment these days |
|
@rawlingsj Previously any comment on a PR would have caused it to be merged. That meant you couldn't review any changes& give feedback without it being merged... not a great idea really. |
|
@jimmidyson where's this configuration and is it sorted for all projects now? The merge comment approach was taken from the kubernetes-client pull request job so I'm wondering if the any comment thing is default configuration - it's not supposed to be like that. If you can let me know where the config is I'll check all the PR jobs. |
|
@rawlingsj I think I've gone through all PR jobs & done it already. Pretty sure it was never part of the base kubernetes client PR job but will double check now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped out nats client library - which seems to be the issue with #338