Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version of GKE Auth support without gcloud #4185

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Initial version of GKE Auth support without gcloud #4185

wants to merge 4 commits into from

Conversation

talatuyarer
Copy link

@talatuyarer talatuyarer commented Jun 3, 2022 •
edited
Loading

Description

I implement new a TokenRefresher for GKE based on Google documentation. This implementation does not need gcloud. Just need a service account and kubeconfig. Detail explaination you can check here

https://cloud.google.com/kubernetes-engine/docs/how-to/api-server-authentication

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@talatuyarer talatuyarer changed the title Initial version of GCP Auth support without gcloud Initial version of GKE Auth support without gcloud Jun 3, 2022
@talatuyarer talatuyarer marked this pull request as ready for review June 3, 2022 16:16
@talatuyarer
Copy link
Author

@manusa Could you take a look my pr ? I tested on GKE cluster. There is no issue. It works as expected.

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

71.9% 71.9% Coverage
0.0% 0.0% Duplication

@manusa manusa requested a review from rohanKanojia June 8, 2022 12:48
manusa
manusa reviewed Jun 8, 2022
View reviewed changes
...netes-client-api/src/main/java/io/fabric8/kubernetes/client/utils/GCPAuthenticatorUtils.java
* @param currentAuthProviderConfig current AuthInfo's AuthProvider config as a map
* @return access token for interacting with Google Kubernetes API
*/
public static CompletableFuture<String> resolveTokenFromAuthConfig(
Copy link
Member

@manusa manusa Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the usage of a CompletableFuture here, both* return statements return sync values CompletableFuture.completedFuture

Also, line 72 seems to be missing a return?

@rohanKanojia
Copy link
Member

@talatuyarer: polite ping, Are you still working on this?

@talatuyarer
Copy link
Author

Hey @rohanKanojia Let me update my pr. We started using my implementation for older version of fabric8. I will send an update commit in this week.

@rohanKanojia
Copy link
Member

@talatuyarer : polite ping, Did you get some time to rebase your PR against latest version?

@shawkins
Copy link
Contributor

Let's rebase and address the review comments with this after #4702

oscerd
oscerd reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite interesting, I hope we could merge it soon.

@talatuyarer
Copy link
Author

I actually have rebased version with current master. I can push before #4702 @shawkins

In addition to this last month I implement AWS EKS support also.

@sunix
Copy link
Collaborator

sunix commented Jul 4, 2023

@talatuyarer: polite ping, Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa left review comments

@oscerd oscerd oscerd left review comments

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@talatuyarer @rohanKanojia @shawkins @sunix @manusa @oscerd