Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): Inconsistency of events when more buttons are used #10143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhe-he
Copy link
Contributor

@zhe-he zhe-he commented Sep 11, 2024

The judgment logic for middle mouse button clicks and right mouse button clicks will definitely trigger mouse:before, even if you set it to false. I changed it to perform the judgment and return when the mouse is pressed, to avoid triggering any subsequent events.

#10027

Copy link

codesandbox bot commented Sep 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@asturur
Copy link
Member

asturur commented Oct 3, 2024

I think something like this needs ot be mixed with the swap from .button to .buttons so that multiple button usage can be leveraged without breaking actual flows.
I ll come back to this after smaller fixes and some larger piece of work is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants