Skip to content

Commit

Permalink
Disable NullCheckerTransformer for all deps of DirectReports
Browse files Browse the repository at this point in the history
Summary:
After adding DirectReports in D61394173, and build major apps again,  a lot more modules fail with circular dependency. That's because they are called by DirectReports module, therefore, if  you give it a dep for DirectReport's module, it will cause circular dependencies

# Solution
We would have to turn off NullChecker for all these modules

Reviewed By: jocelynluizzi13

Differential Revision: D61395268

fbshipit-source-id: a432f1990320114cf20760e321cb7e0696b9d90c
  • Loading branch information
Jingbo Yang authored and facebook-github-bot committed Aug 22, 2024
1 parent 88a8779 commit 4369084
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions java/com/facebook/soloader/BUCK
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ load("//tools/build_defs/oss:soloader_defs.bzl", "fb_core_android_library", "fb_

fb_core_android_library(
name = "soloader",
# NullChecker use this module, so using nullchecker here will result in circular dependency
nullchecker_mode = "none",
proguard_config = "soloader.pro",
provided_deps = [
"//deps:jsr_305",
Expand Down Expand Up @@ -32,6 +34,8 @@ LOADER_SRCS = glob(
fb_core_android_library(
name = "loader",
srcs = LOADER_SRCS,
# NullChecker use this module, so using nullchecker here will result in circular dependency
nullchecker_mode = "none",
proguard_config = "soloader.pro",
provided_deps = [
":annotation",
Expand Down

0 comments on commit 4369084

Please sign in to comment.