Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdq] Fix pdq CI failure caused by ubuntu-latest 22.04 --> 24.04 update #1758

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

ianwal
Copy link
Contributor

@ianwal ianwal commented Feb 9, 2025

Summary

Fix pdq CI test failure on Ubuntu 24.04 (#1757 for pdq only)

imagemagick isn't installed by Ubuntu 24.04 by default anymore, and it's a runtime dependency of CImg for decoding images. Installing it fixes the issue.

Changes

  • Install imagemagick before building pdq

    • This is the ONLY required change to get the build working.
  • Added multiple OS profiles to the CI to make it easier to spot a failure caused by OS differences in the future.

    • The only thing I had to debug this issue with was this runtime message: [CImg] *** CImgIOException *** [instance(0,0,0,0,(nil),non-shared)] CImg<unsigned char>::load(): Failed to recognize format of file './reg_test/../../data/reg-test-input/dih/bridge-1-original.jpg'. It would have been very helpful to be able to see the failure was only occurring on one profile but not the other.
  • Updated checkout action from v2 to v4

Test Plan

CI should fail without the changes (first commit).

After the changes, CI should pass on both 22.04 and 24.04.

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@Dcallies Dcallies merged commit 786004b into facebook:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants