[pdq] Fix pdq CI failure caused by ubuntu-latest 22.04 --> 24.04 update #1758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix pdq CI test failure on Ubuntu 24.04 (#1757 for pdq only)
imagemagick
isn't installed by Ubuntu 24.04 by default anymore, and it's a runtime dependency of CImg for decoding images. Installing it fixes the issue.Changes
Install
imagemagick
before building pdqAdded multiple OS profiles to the CI to make it easier to spot a failure caused by OS differences in the future.
[CImg] *** CImgIOException *** [instance(0,0,0,0,(nil),non-shared)] CImg<unsigned char>::load(): Failed to recognize format of file './reg_test/../../data/reg-test-input/dih/bridge-1-original.jpg'.
It would have been very helpful to be able to see the failure was only occurring on one profile but not the other.Updated
checkout
action from v2 to v4Test Plan
CI should fail without the changes (first commit).
After the changes, CI should pass on both 22.04 and 24.04.