Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #8261

Closed
wants to merge 2 commits into from
Closed

chore: upgrade dependencies #8261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79097b2
chore: upgrade dependencies
lex111 Oct 28, 2022
2a7cb54
Try again
lex111 Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"react-test-renderer": "^17.0.2",
"remark-parse": "^8.0.2",
"rimraf": "^3.0.2",
"sharp": "^0.31.0",
"sharp": "^0.31.1",
"strip-ansi": "^6.0.1",
"stylelint": "^14.11.0",
"stylelint-config-prettier": "^9.0.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-cssnano-preset/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
},
"dependencies": {
"cssnano-preset-advanced": "^5.3.8",
"postcss": "^8.4.16",
"postcss": "^8.4.18",
"postcss-sort-media-queries": "^4.3.0",
"tslib": "^2.4.0"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-mdx-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
},
"license": "MIT",
"dependencies": {
"@babel/parser": "^7.19.0",
"@babel/traverse": "^7.19.0",
"@babel/parser": "^7.20.0",
"@babel/traverse": "^7.20.0",
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/utils": "^3.0.0-alpha.0",
"@mdx-js/mdx": "^1.6.22",
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-migrate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"docusaurus-migrate": "bin/index.mjs"
},
"dependencies": {
"@babel/core": "^7.19.0",
"@babel/preset-env": "^7.19.0",
"@babel/core": "^7.19.6",
"@babel/preset-env": "^7.19.4",
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/utils": "^3.0.0-alpha.0",
"@mapbox/hast-util-to-jsx": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-plugin-ideal-image/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"@docusaurus/utils-validation": "^3.0.0-alpha.0",
"@endiliey/react-ideal-image": "^0.0.11",
"react-waypoint": "^10.3.0",
"sharp": "^0.31.0",
"sharp": "^0.31.1",
"tslib": "^2.4.0",
"webpack": "^5.74.0"
},
Expand Down
8 changes: 4 additions & 4 deletions packages/docusaurus-plugin-pwa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@
},
"license": "MIT",
"dependencies": {
"@babel/core": "^7.19.0",
"@babel/preset-env": "^7.19.0",
"@babel/core": "^7.19.6",
"@babel/preset-env": "^7.19.4",
"@docusaurus/core": "^3.0.0-alpha.0",
"@docusaurus/theme-common": "^3.0.0-alpha.0",
"@docusaurus/theme-translations": "^3.0.0-alpha.0",
"@docusaurus/types": "^3.0.0-alpha.0",
"@docusaurus/utils": "^3.0.0-alpha.0",
"@docusaurus/utils-validation": "^3.0.0-alpha.0",
"babel-loader": "^8.2.5",
"babel-loader": "^9.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major deps upgrades often have breaking changes that might lead ourselves to have breaking changes too.

https://github.com/babel/babel-loader/releases/tag/v9.0.0

In this case it doesn't seem to be a problem (even though we allow configuring babel plugins) but the 9.0 was released only 20h ago.

For safety, I'd prefer to stay on 8.x, and keep such upgrades for the next major versions.

IE: don't do any risky change just before a minor release. If a PR feels too risky I'd prefer to not backport it. Releasing a minor takes more time than before and I don't want to have to release a 2.2.1 if possible.

In general, I'd prefer to avoid having to backport a deps upgrade PR just before a release. Let's merge those PRs a bit upfront, see if there's any issue, and only then backport it.

"clsx": "^1.2.1",
"core-js": "^3.25.1",
"core-js": "^3.26.0",
"terser-webpack-plugin": "^5.3.6",
"tslib": "^2.4.0",
"webpack": "^5.74.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"infima": "0.2.0-alpha.42",
"lodash": "^4.17.21",
"nprogress": "^0.2.0",
"postcss": "^8.4.16",
"postcss": "^8.4.18",
"prism-react-renderer": "^1.3.5",
"prismjs": "^1.29.0",
"react-router-dom": "^5.3.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/docusaurus-theme-search-algolia/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"copy:watch": "node ../../admin/scripts/copyUntypedFiles.js --watch"
},
"dependencies": {
"@docsearch/react": "^3.2.1",
"@docsearch/react": "^3.3.0",
Copy link
Collaborator

@slorber slorber Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently, there are type-related breaking changes in this new version @shortcuts @Haroenv

This upgrade leads to failures while type-checking our website: https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683

Run yarn workspace website typecheck
yarn workspace v1.22.19
yarn run v1.22.19
$ tsc
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(7,7[4](https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683#step:7:5)): error TS2339: Property 'liteClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(8,7[5](https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683#step:7:6)): error TS2339: Property 'searchClient' does not exist on type 'typeof import("/home/runner/work/docusaurus/docusaurus/node_modules/@algolia/client-search/dist/client-search")'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(20,23): error TS2[6](https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683#step:7:7)94: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'LegacySearchMethodProps'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(24,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchForFacetValuesResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(2[8](https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683#step:7:9),23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SearchResponse'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(32,23): error TS26[9](https://github.com/facebook/docusaurus/actions/runs/3343786713/jobs/5537374683#step:7:10)4: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'HighlightResult'.
Error: ../node_modules/@algolia/autocomplete-preset-algolia/dist/esm/types/algoliasearch.d.ts(36,23): error TS2694: Namespace '"/home/runner/work/docusaurus/docusaurus/node_modules/algoliasearch/lite"' has no exported member 'SnippetResult'.

Seems related to algolia/autocomplete#1002

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know, the ts-ignore comments were removed :( Will fix!

"@docusaurus/core": "^3.0.0-alpha.0",
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/plugin-content-docs": "^3.0.0-alpha.0",
Expand All @@ -42,7 +42,7 @@
"@docusaurus/utils": "^3.0.0-alpha.0",
"@docusaurus/utils-validation": "^3.0.0-alpha.0",
"algoliasearch": "^4.14.2",
"algoliasearch-helper": "^3.11.0",
"algoliasearch-helper": "^3.11.1",
"clsx": "^1.2.1",
"eta": "^1.12.3",
"fs-extra": "^10.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@types/history": "^4.7.11",
"@types/react": "*",
"commander": "^5.1.0",
"joi": "^17.6.0",
"joi": "^17.6.4",
"react-helmet-async": "^1.3.0",
"utility-types": "^3.10.0",
"webpack": "^5.74.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-utils-validation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"dependencies": {
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/utils": "^3.0.0-alpha.0",
"joi": "^17.6.0",
"joi": "^17.6.4",
"js-yaml": "^4.1.0",
"tslib": "^2.4.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/docusaurus-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"license": "MIT",
"dependencies": {
"@docusaurus/logger": "^3.0.0-alpha.0",
"@svgr/webpack": "^6.3.1",
"@svgr/webpack": "^6.5.0",
"file-loader": "^6.2.0",
"fs-extra": "^10.1.0",
"github-slugger": "^1.4.0",
Expand Down
32 changes: 16 additions & 16 deletions packages/docusaurus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,16 @@
"url": "https://github.com/facebook/docusaurus/issues"
},
"dependencies": {
"@babel/core": "^7.19.0",
"@babel/generator": "^7.19.0",
"@babel/core": "^7.19.6",
"@babel/generator": "^7.20.0",
"@babel/plugin-syntax-dynamic-import": "^7.8.3",
"@babel/plugin-transform-runtime": "^7.18.10",
"@babel/preset-env": "^7.19.0",
"@babel/plugin-transform-runtime": "^7.19.6",
"@babel/preset-env": "^7.19.4",
"@babel/preset-react": "^7.18.6",
"@babel/preset-typescript": "^7.18.6",
"@babel/runtime": "^7.19.0",
"@babel/runtime-corejs3": "^7.19.0",
"@babel/traverse": "^7.19.0",
"@babel/runtime": "^7.20.0",
"@babel/runtime-corejs3": "^7.20.0",
"@babel/traverse": "^7.20.0",
"@docusaurus/cssnano-preset": "^3.0.0-alpha.0",
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/mdx-loader": "^3.0.0-alpha.0",
Expand All @@ -51,9 +51,9 @@
"@docusaurus/utils-common": "^3.0.0-alpha.0",
"@docusaurus/utils-validation": "^3.0.0-alpha.0",
"@slorber/static-site-generator-webpack-plugin": "^4.0.7",
"@svgr/webpack": "^6.3.1",
"autoprefixer": "^10.4.8",
"babel-loader": "^8.2.5",
"@svgr/webpack": "^6.5.0",
"autoprefixer": "^10.4.12",
"babel-loader": "^9.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

"babel-plugin-dynamic-import-node": "^2.3.3",
"boxen": "^6.2.1",
"chalk": "^4.1.2",
Expand All @@ -63,24 +63,24 @@
"combine-promises": "^1.1.0",
"commander": "^5.1.0",
"copy-webpack-plugin": "^11.0.0",
"core-js": "^3.25.1",
"core-js": "^3.26.0",
"css-loader": "^6.7.1",
"css-minimizer-webpack-plugin": "^4.0.0",
"css-minimizer-webpack-plugin": "^4.2.2",
"cssnano": "^5.1.13",
"del": "^6.1.1",
"detect-port": "^1.3.0",
"detect-port": "^1.5.1",
"escape-html": "^1.0.3",
"eta": "^1.12.3",
"file-loader": "^6.2.0",
"fs-extra": "^10.1.0",
"html-minifier-terser": "^6.1.0",
"html-minifier-terser": "^7.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same, what are the breaking changes of this new version? How does it affect us? Again I'd rather stick to 6.x particularly if I need to backport this PR => avoid risky changes for PRs to backport

"html-tags": "^3.2.0",
"html-webpack-plugin": "^5.5.0",
"import-fresh": "^3.3.0",
"leven": "^3.1.0",
"lodash": "^4.17.21",
"mini-css-extract-plugin": "^2.6.1",
"postcss": "^8.4.16",
"postcss": "^8.4.18",
"postcss-loader": "^7.0.1",
"prompts": "^2.4.2",
"react-dev-utils": "^12.0.1",
Expand All @@ -101,7 +101,7 @@
"wait-on": "^6.0.1",
"webpack": "^5.74.0",
"webpack-bundle-analyzer": "^4.6.1",
"webpack-dev-server": "^4.11.0",
"webpack-dev-server": "^4.11.1",
"webpack-merge": "^5.8.0",
"webpackbar": "^5.0.2"
},
Expand Down
4 changes: 2 additions & 2 deletions packages/lqip-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
"@docusaurus/logger": "^3.0.0-alpha.0",
"file-loader": "^6.2.0",
"lodash": "^4.17.21",
"sharp": "^0.31.0",
"sharp": "^0.31.1",
"tslib": "^2.4.0"
},
"engines": {
"node": ">=16.14"
},
"devDependencies": {
"@types/file-loader": "^5.0.1",
"@types/sharp": "^0.30.5"
"@types/sharp": "^0.31.0"
}
}
6 changes: 3 additions & 3 deletions website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"typecheck": "tsc"
},
"dependencies": {
"@crowdin/cli": "^3.7.10",
"@crowdin/crowdin-api-client": "^1.19.1",
"@crowdin/cli": "^3.9.0",
"@crowdin/crowdin-api-client": "^1.19.2",
"@docusaurus/core": "^3.0.0-alpha.0",
"@docusaurus/logger": "^3.0.0-alpha.0",
"@docusaurus/plugin-client-redirects": "^3.0.0-alpha.0",
Expand All @@ -45,8 +45,8 @@
"@docusaurus/remark-plugin-npm2yarn": "^3.0.0-alpha.0",
"@docusaurus/theme-classic": "^3.0.0-alpha.0",
"@docusaurus/theme-common": "^3.0.0-alpha.0",
"@docusaurus/theme-mermaid": "^3.0.0-alpha.0",
"@docusaurus/theme-live-codeblock": "^3.0.0-alpha.0",
"@docusaurus/theme-mermaid": "^3.0.0-alpha.0",
"@docusaurus/utils": "^3.0.0-alpha.0",
"@docusaurus/utils-common": "^3.0.0-alpha.0",
"@popperjs/core": "^2.11.6",
Expand Down
Loading