Skip to content

Commit

Permalink
Downgrade installreferrer dep (#671)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #671

See #665
and https://stackoverflow.com/questions/59263642/install-referrer-library-v1-1-adds-permissions

Reviewed By: jingping2015

Differential Revision: D19643851

fbshipit-source-id: 7d285fd22b117338de9b256877f11a9f1fe94034
  • Loading branch information
Maxim Goretskyy authored and facebook-github-bot committed Feb 3, 2020
1 parent 84ab277 commit 1d45bc5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion facebook-core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dependencies {
implementation "com.android.support:support-core-utils:${project.ext.supportLibraryVersion}"

//https://developer.android.com/google/play/installreferrer/library.html#java
implementation 'com.android.installreferrer:installreferrer:1.1'
implementation 'com.android.installreferrer:installreferrer:1.0' //there are issues with 1.1 regarding permissions, asks for unnecessary permissions

// Unit Tests
testImplementation 'junit:junit:4.12'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public void onInstallReferrerSetupFinished(int responseCode) {
ReferrerDetails response;
try {
response = referrerClient.getInstallReferrer();
} catch (RemoteException | RuntimeException e) {
} catch (Exception e) {
return;
}

Expand Down

1 comment on commit 1d45bc5

@toxikman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Google has fixed this manifest problem in install-referrer version 2.0. Perhaps the Facebook team should consider updating to this if the latest version is important to have.

Please sign in to comment.