Ramp up - Add tests for Products Delete API #2865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@carterbuce has updated the pull request. You must reimport the pull request before landing. |
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
carterbuce
force-pushed
the
products-api-tests
branch
from
f7ac106 to
c0a8753
Compare
|
@carterbuce has updated the pull request. You must reimport the pull request before landing. |
|
@carterbuce has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@carterbuce merged this pull request in 5b445d7. |
gurtejrehal
pushed a commit
to gurtejrehal/facebook-for-woocommerce
that referenced
this pull request
Feb 11, 2025
Summary: ### Changes proposed in this Pull Request: - Adding simple Request and Response tests to the Products Delete API to increase code coverage and as a ramp-up work item for getting used to the dev flow in this repository - [x] Do the changed files pass `phpcs` checks? Please remove `phpcs:ignore` comments in changed files and fix any issues, or delete if not practical. Pull Request resolved: facebook#2865 Test Plan: - `phpunit tests/Unit/Api/ProductCatalog/Products/Delete` Reviewed By: jczhuoMeta, vinkmeta Differential Revision: D68915742 Pulled By: carterbuce fbshipit-source-id: d7fb475ccc1f0c24632e8579d56feb5cb4bc54d2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Adding simple Request and Response tests to the Products Delete API to increase code coverage and as a ramp-up work item for getting used to the dev flow in this repository
Do the changed files pass
phpcschecks? Please removephpcs:ignorecomments in changed files and fix any issues, or delete if not practical.Test Plan:
phpunit tests/Unit/Api/ProductCatalog/Products/Delete