-
Notifications
You must be signed in to change notification settings - Fork 953
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ready needs to be able to handle asynchronous code
Summary: A previous diff introduced the isReady state as to make it possible to serve HTML content sooner than we are ready. This worked great on debugging. As I was testing a release, it was discovered that there was a race condition and the server was not ready when it was already handling upgrade events. To solve this, I've added another state flag in the form of a promise. This one, can be waited on. This is used then during upgrade events as we can safely wait until the server is ready to accept incoming connections before proceeding with the upgrade. Problem is shown below: {F1080003241} {F1080003356} Reviewed By: passy Differential Revision: D48829453 fbshipit-source-id: e148a392bbe66dd91710e32871e270c8950e25c2
- Loading branch information
1 parent
072d618
commit 457767c
Showing
1 changed file
with
42 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters