Skip to content

Commit

Permalink
Disable client identity propagation in the OSS build
Browse files Browse the repository at this point in the history
  • Loading branch information
mszabo-wikia committed Oct 2, 2024
1 parent d5b1532 commit 816fd71
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion mcrouter/ServerOnRequest.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@
#include <cassert>
#include <memory>

#ifndef MCROUTER_OSS_BUILD
#include "core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h"
#endif

#include "mcrouter/CarbonRouterClient.h"
#include "mcrouter/RequestAclChecker.h"
#include "mcrouter/config.h"
Expand Down Expand Up @@ -165,7 +168,8 @@ class ServerOnRequest {
auto& reqRef = rctx->req;
auto& ctxRef = rctx->ctx;

// Set hashed TLS client identities on request to propogate from proxy ->
#ifndef MCROUTER_OSS_BUILD
// Set hashed TLS client identities on request to propagate from proxy ->
// memcache server only IF enableKeyClientBinding_ is enabled.
if (FOLLY_UNLIKELY(enableKeyClientBinding_) &&
ctxRef.getThriftRequestContext()) {
Expand All @@ -179,6 +183,8 @@ class ServerOnRequest {
std::get<std::string>(mayBeHashedIdentities.value()));
}
}
#endif

// if we are reusing the request buffer, adjust the start offset and set
// it to the request.
if (reusableRequestBuffer) {
Expand Down

0 comments on commit 816fd71

Please sign in to comment.