chore: Split out data attributes to separate files

facebook · Apr 4, 2024 · 9a15d99 · 9a15d99
1 parent 429e2fe
commit 9a15d99
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 6 deletions.
diff --git a/packages/react-strict-dom/src/shared/strictAttributes.js b/packages/react-strict-dom/src/shared/strictAttributes.js
@@ -7,7 +7,10 @@
  * @flow strict
  */
 
+import { strictDataAttributeKeys } from './strictDataAttributes';
+
 export const strictAttributeSet: Set<string> = new Set([
+  ...strictDataAttributeKeys,
   'alt', // img
   'aria-activedescendant',
   'aria-atomic',
@@ -62,7 +65,7 @@ export const strictAttributeSet: Set<string> = new Set([
   'checked', // input
   'children',
   'crossOrigin', // img
-  'data-testid',
+
   'decoding', // img
   'defaultChecked', // input
   'defaultValue', // input, textarea
@@ -142,8 +145,6 @@ export const strictAttributeSet: Set<string> = new Set([
   'value', // input
   'width', // img
 
-  'data-imgperflogname', // TEMPORARY
-  'data-visualcompletion', // TEMPORARY
   'onMouseDown', // TEMPORARY
   'onMouseEnter', // TEMPORARY
   'onMouseLeave', // TEMPORARY

diff --git a/packages/react-strict-dom/src/shared/strictDataAttributes.js b/packages/react-strict-dom/src/shared/strictDataAttributes.js
@@ -0,0 +1,14 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict
+ */
+
+export const strictDataAttributeKeys: $ReadOnlyArray<string> = [
+  'data-testid',
+  'data-imgperflogname', // TEMPORARY
+  'data-visualcompletion' // TEMPORARY
+];
diff --git a/packages/react-strict-dom/src/types/StrictReactDOMDataAttrs.js b/packages/react-strict-dom/src/types/StrictReactDOMDataAttrs.js
@@ -0,0 +1,14 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict
+ */
+
+export type DataAttrs = $ReadOnly<{
+  'data-imgperflogname'?: string, // TEMPORARY
+  'data-testid'?: string,
+  'data-visualcompletion'?: string // TEMPORARY
+}>;
diff --git a/packages/react-strict-dom/src/types/StrictReactDOMProps.js b/packages/react-strict-dom/src/types/StrictReactDOMProps.js
@@ -8,6 +8,7 @@
  */
 
 import type { StrictElement } from './StrictElement';
+import type { DataAttrs } from './StrictReactDOMDataAttrs';
 import type { ReactRef } from './Utilities';
 import type { Styles } from './styles';
 
@@ -202,12 +203,10 @@ type EventProps = $ReadOnly<{
 export type StrictReactDOMProps = $ReadOnly<{
   ...AriaProps,
   ...EventProps,
+  ...DataAttrs,
   autoCapitalize?: 'off' | 'none' | 'on' | 'sentences' | 'words' | 'characters',
   autoFocus?: boolean,
   children?: React$Node,
-  'data-imgperflogname'?: string, // TEMPORARY
-  'data-testid'?: string,
-  'data-visualcompletion'?: string, // TEMPORARY
   dir?: 'auto' | 'ltr' | 'rtl',
   elementTiming?: string,
   enterKeyHint?: