-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to use Flow's new StringPrefix feature #171
base: main
Are you sure you want to change the base?
Conversation
compressed-size: runtime library Size change: 0.00 kB View unchanged
|
workflow: benchmarks (native)Comparison of benchmark test results, measured in operations per second (higher is faster.)
|
@@ -280,9 +280,9 @@ type EventProps = $ReadOnly<{ | |||
}>; | |||
|
|||
export type StrictReactDOMProps = $ReadOnly<{ | |||
[StringPrefix<'data-'>]: ?string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if the generated TS types work as expected?
If so, this LGTM.
There seems to be a Flow bug with the |
This is not ready to merge, I put it up for the flow team. We've been talking about the issues with the API and it's translation to TS. They're looking into it |
Fix #71