ci (eslint-e2e): exclude nested node_modules from cache

This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens. ci (eslint-e2e): exclude nested `node_modules` from cache This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens.
facebook · Feb 17, 2025 · 6ea4c0d · 6ea4c0d
1 parent 077a4b0
commit 6ea4c0d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/.github/workflows/runtime_eslint_plugin_e2e.yml b/.github/workflows/runtime_eslint_plugin_e2e.yml
@@ -40,7 +40,7 @@ jobs:
         uses: actions/cache@v4
         id: node_modules
         with:
-          path: "**/node_modules"
+          path: "node_modules"
           key: runtime-eslint_e2e-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
       - name: Ensure clean build directory
         run: rm -rf build

diff --git a/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.ts b/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.ts
@@ -184,7 +184,9 @@ const rule = {
       // Get the current scope.
       const scope = scopeManager.acquire(node);
       if (!scope) {
-        throw new Error('Unable to acquire scope for the current node.');
+        throw new Error(
+          'Unable to acquire scope for the current node. This is a bug in eslint-plugin-react-hooks, please file an issue.',
+        );
       }
 
       // Find all our "pure scopes". On every re-render of a component these