Skip to content

Commit

Permalink
ci (eslint-e2e): exclude nested node_modules from cache
Browse files Browse the repository at this point in the history
This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens.
  • Loading branch information
michaelfaith committed Feb 16, 2025
1 parent 077a4b0 commit ff47b9e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/runtime_eslint_plugin_e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,11 @@ jobs:
uses: actions/cache@v4
id: node_modules
with:
path: "**/node_modules"
path: "node_modules"
key: runtime-eslint_e2e-node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }}
- name: Ensure clean build directory
run: rm -rf build
- run: yarn install --frozen-lockfile
- run: yarn install
- name: Build plugin
working-directory: fixtures/eslint-v${{ matrix.eslint_major }}
run: node build.mjs
Expand Down
4 changes: 3 additions & 1 deletion packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,9 @@ const rule = {
// Get the current scope.
const scope = scopeManager.acquire(node);
if (!scope) {
throw new Error('Unable to acquire scope for the current node.');
throw new Error(
'Unable to acquire scope for the current node. This is a bug in eslint-plugin-react-hooks, please file an issue.',
);
}

// Find all our "pure scopes". On every re-render of a component these
Expand Down

0 comments on commit ff47b9e

Please sign in to comment.