Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][Babel] Refactor insertion of compiled fn #30085

Closed
wants to merge 2 commits into from
Closed

[compiler][Babel] Refactor insertion of compiled fn #30085

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff3783d
[compiler][Babel] Refactor insertion of compiled fn
gsathya Jun 25, 2024
fc102f9
Update on "[compiler][Babel] Refactor insertion of compiled fn"
gsathya Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Program.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,13 +454,7 @@ export function compileProgram(
* error elsewhere in the file, regardless of bailout mode.
*/
for (const { originalFn, compiledFn } of compiledFns) {
const transformedFn = createNewFunctionNode(originalFn, compiledFn);

if (gating != null) {
insertGatedFunctionDeclaration(originalFn, transformedFn, gating);
} else {
originalFn.replaceWith(transformedFn);
}
insertCompiledFn(originalFn, compiledFn, gating);
}

// Forget compiled the component, we need to update existing imports of useMemoCache
Expand All @@ -484,6 +478,19 @@ export function compileProgram(
}
}

function insertCompiledFn(
originalFn: BabelFn,
compiledFn: CodegenFunction,
gating: ExternalFunction | null
): void {
const transformedFn = createNewFunctionNode(originalFn, compiledFn);
if (gating != null) {
insertGatedFunctionDeclaration(originalFn, transformedFn, gating);
} else {
originalFn.replaceWith(transformedFn);
}
}

function getReactFunctionType(
fn: BabelFn,
pass: CompilerPass
Expand Down