[compiler] Introduce OutlinedFunctionExpression HIR #30088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very similar to the existing FunctionExpression HIR node intentionally, so that we can share all the infra between them. There's a new `outlinedFunc` field on this that will hold the newly created function that needs to be compiled outside the function body. The `loweredFunc` will hold the updated HIR for rendering the outlinedFunc in the callback. [ghstack-poisoned]
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jun 25, 2024
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: f5d2feb...14848e0 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
This is very similar to the existing FunctionExpression HIR node intentionally, so that we can share all the infra between them. There's a new `outlinedFunc` field on this that will hold the newly created function that needs to be compiled outside the function body. The `loweredFunc` will hold the updated HIR for rendering the outlinedFunc in the callback. [ghstack-poisoned]
josephsavona
requested changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is very similar to the existing FunctionExpression HIR node
intentionally, so that we can share all the infra between them.
There's a new
outlinedFuncfield on this that will hold the newlycreated function that needs to be compiled outside the function body.
The
loweredFuncwill hold the updated HIR for rendering theoutlinedFunc in the callback.