fix: remove mountWorkInProgressOffscreenFiber function #31473
+6
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Thank you so much for your great contribution to the Javascript ecosystem. I think this PR is still a valid PR. I'd appreciate it if you could check it :) |
|
Hello, @sebmarkbage Hi, I'd really appreciate it if you could check that PR. Have a nice day ! |
github-actions
bot
removed
the
Resolution: Stale
|
Hello, @eps1lon ! I think this PR is still a valid, it'd be nice if you could check it out ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I deleted
mountWorkInProgressOffscreenFiber.The prop type of
createFiberFromOffscreenis now specified asOffscreenProps, not any.Therefore, I thought
mountWorkInProgressOffscreenFiberwas an unnecessary function.How did you test this change?