fix(eslint-plugin-react-hooks): remove experimental checks involving useEffectEvent #32276
+2
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…useEffectEvent Contributing to facebook#32240, this change removes the experimental `useEffectEvent` checks in the two react hooks eslint rule. As the api is refined, and the compiler rule(s) are incorporated into this plugin, these checks will be covered then.
michaelfaith
force-pushed
the
fix/remove-experimental-eslint-rule-checks
branch
from
02c1846 to
2a91f47
Compare
poteto
approved these changes
Jan 31, 2025
|
For what it’s worth, the current However, I understand of course that the hook is experimental and its support in Looking forward to hopefully having this hook available in a stable release eventually, along with support in the future of the eslint plugin. |
|
Closing this as the team decided to leave it as-is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Contributing to #32240, this change removes the experimental
useEffectEventchecks in the two react hooks ESLint rules. As the api is refined, and the compiler rule(s) are incorporated into this plugin, these checks will be covered then.