build: add support to the rollup build for building typescript packages #32393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Comparing: e670e72...8da2860 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
michaelfaith
force-pushed
the
build/add-typescript-support
branch
from
7706916 to
7f7818f
Compare
michaelfaith
force-pushed
the
build/add-typescript-support
branch
from
7f7818f to
d33cf75
Compare
poteto
approved these changes
Feb 16, 2025
scripts/rollup/build.js
Outdated
| }; | ||
| }, | ||
| }, | ||
| bundle.tsconfig |
There was a problem hiding this comment.
Suggested change
| bundle.tsconfig | |
| bundle.tsconfig != null |
There was a problem hiding this comment.
Let's keep any comparisons as specific as possible
poteto
requested changes
Feb 16, 2025
There was a problem hiding this comment.
I took a look at the built files and I noticed that the d.ts files were missing, could you check and see?
This is because we haven't added the {
+ name: 'eslint-plugin-react-hooks',
- bundleTypes: [NODE_DEV, NODE_PROD],
+ bundleTypes: [NODE_DEV, NODE_PROD, CJS_DTS],
moduleType: ISOMORPHIC,
- entry: 'eslint-plugin-react-hooks',
+ entry: 'eslint-plugin-react-hooks/src/index.ts',
global: 'ESLintPluginReactHooks',
minifyWithProdErrorCodes: false,
wrapWithModuleBoundaries: false,
externals: [],
+ tsconfig: './packages/eslint-plugin-react-hooks/tsconfig.json',
}, |
This change adds support to the rollup build script for building packages with typescript source. In order for a bundle to be picked up by the new flow, the bundle definition should have a `tsconfig` property with a path to the project's tsconfig. There's also two new bundle types that such packages can request to be built: `ESM_DTS` and `CJS_DTS`, which will create the corresponding `.d.ts` bundle.
This change updates the base jest config to use `babel-jest` with the typescript preset to transform `.ts` files. The existing `preprocessor`, which intercepts ts files, appears to be pretty old and wasn't implemented with entire packages of typescript source in mind.
michaelfaith
force-pushed
the
build/add-typescript-support
branch
from
d33cf75 to
b0b88b2
Compare
poteto
added a commit
that referenced
this pull request
Feb 16, 2025
…pe declarations (#32240) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This change converts the eslint hooks plugin to typescript, which also allows us to include type declarations in the package, for those using [typescript eslint configs](https://eslint.org/blog/2025/01/eslint-v9.18.0-released/#stable-typescript-configuration-file-support). ### Constituent changes that should land before this one - [x] ~#32276 - [x] #32279 - [x] #32283 - [x] #32393 - [x] #32396 Closes #30119 --------- Co-authored-by: Lauren Tan <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 16, 2025
…pe declarations (#32240) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This change converts the eslint hooks plugin to typescript, which also allows us to include type declarations in the package, for those using [typescript eslint configs](https://eslint.org/blog/2025/01/eslint-v9.18.0-released/#stable-typescript-configuration-file-support). ### Constituent changes that should land before this one - [x] ~#32276 - [x] #32279 - [x] #32283 - [x] #32393 - [x] #32396 Closes #30119 --------- Co-authored-by: Lauren Tan <[email protected]> DiffTrain build for [5adf402](5adf402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #32240 this change adds support to the rollup build script for building packages with typescript source. In order for a bundle to be picked up by the new flow, the bundle definition should have a
tsconfigproperty with a path to the project's tsconfig.There's also two new bundle types that such packages can request to be built:
ESM_DTSandCJS_DTS, which will create the corresponding.d.tsbundle.