Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-react-hooks): update engines declaration #32458

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

michaelfaith
Copy link
Contributor

In preparation for the merging of the compiler plugin into this one (#32416), this change proactively updates the plugin's engines declaration to require Node versions greater than or equal to 18

BREAKING CHANGE

In preparation for the merging of the compiler plugin into this one (facebook#32416), this change proactively updates the plugin's `engines` declaration to require Node versions greater than or equal to 18

BREAKING CHANGE
@react-sizebot
Copy link

react-sizebot commented Feb 22, 2025

Comparing: 56c7d10...207097a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.24 kB 518.24 kB = 92.43 kB 92.43 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 570.57 kB 570.57 kB = 101.56 kB 101.56 kB
facebook-www/ReactDOM-prod.classic.js = 638.06 kB 638.06 kB = 112.28 kB 112.28 kB
facebook-www/ReactDOM-prod.modern.js = 628.38 kB 628.38 kB = 110.70 kB 110.70 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0adba61

@poteto poteto marked this pull request as ready for review February 28, 2025 16:03
@poteto poteto merged commit 11ca4f6 into facebook:main Feb 28, 2025
166 of 167 checks passed
@michaelfaith michaelfaith deleted the build/eslint-engines branch February 28, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants