Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability for custom constraint evaluators #217

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Add ability for custom constraint evaluators #217

merged 1 commit into from
Sep 29, 2023

Conversation

Al-Kindi-0
Copy link
Contributor

Addresses #181

irakliyk
irakliyk requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! I left a few comments inline about how we can simplify the trait a bit.

prover/src/constraints/evaluator.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator.rs Outdated Show resolved Hide resolved
prover/src/constraints/evaluator.rs Outdated Show resolved Hide resolved
prover/src/lib.rs Outdated Show resolved Hide resolved
examples/src/fibonacci/fib2/mod.rs Outdated Show resolved Hide resolved
examples/src/fibonacci/fib2/prover.rs Outdated Show resolved Hide resolved
irakliyk
irakliyk requested changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple more comments inline.

prover/src/constraints/evaluator.rs Show resolved Hide resolved
winterfell/src/lib.rs Outdated Show resolved Hide resolved
winterfell/src/lib.rs Outdated Show resolved Hide resolved
@Al-Kindi-0
feat: add ability for custom constraint evaluators
6fecb6a 
fix: simplify constraint eval trait + misc nits

fix: some nits
irakliyk
irakliyk approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@irakliyk irakliyk merged commit 19c0dcd into facebook:main Sep 29, 2023
9 checks passed
@irakliyk irakliyk mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-Kindi-0 @irakliyk @facebook-github-bot