Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptable options argument to verification #219

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add acceptable options argument to verification #219

merged 1 commit into from
Oct 17, 2023

Conversation

Al-Kindi-0
Copy link
Contributor

Addresses #160

@irakliyk irakliyk self-requested a review October 16, 2023 23:58
irakliyk
irakliyk requested changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few small comments inline.

verifier/src/errors.rs Outdated Show resolved Hide resolved
verifier/src/errors.rs Outdated Show resolved Hide resolved
verifier/src/errors.rs Outdated Show resolved Hide resolved
verifier/src/errors.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Outdated Show resolved Hide resolved
@Al-Kindi-0 Al-Kindi-0 force-pushed the al-acceptable-options branch 2 times, most recently from 064daa8 to 28bf2b1 Compare October 17, 2023 09:34
irakliyk
irakliyk approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a couple of small comments inline. Once these are addressed, we can merge.

verifier/src/lib.rs Outdated Show resolved Hide resolved
verifier/src/lib.rs Show resolved Hide resolved
@irakliyk irakliyk mentioned this pull request Oct 17, 2023
Closed
@Al-Kindi-0
feat: add acceptable options to verification
68b3fa8 
fix: minor nits and refactorings

fix: minor nits and refactorings

fix: minor nits
irakliyk
irakliyk approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@irakliyk irakliyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@irakliyk irakliyk merged commit 4d5157b into facebook:main Oct 17, 2023
9 checks passed
@irakliyk irakliyk mentioned this pull request Oct 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irakliyk irakliyk irakliyk approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Al-Kindi-0 @irakliyk @facebook-github-bot