[WS-main] Miscellaneous fixes to unblock WS on Hopper #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
manman-ren
reviewed
Feb 18, 2025
| auto &barSyncOp = *ptxBuilder.create<>("bar.sync"); | ||
| barSyncOp(ptxBuilder.newConstantOperand(barId), | ||
| ptxBuilder.newConstantOperand(numThreads)); | ||
| auto voidTy = void_ty(op->getContext()); |
There was a problem hiding this comment.
Thanks for the fixes! For my own understanding, why do we need to lower manually for WS-main but not ws branch?
There was a problem hiding this comment.
It's there in the ws branch too. As mlir::gpu::BarrierOp lowering is supposed to be handled by latest llvm, upstream removes the explicit lowering here. But it's needed for WS to support named barriers so I'm bring it back.
manman-ren
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.