Update OSS black linter version to 24.4.0 #1001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56340613 |
aakhundov
added a commit
to aakhundov/AITemplate-1
that referenced
this pull request
Apr 19, 2024
Summary: There are some [linter errors](https://github.com/facebookincubator/AITemplate/actions/runs/8680791999/job/23802124952) in OSS trunk caused by D54447738 updating black version to 2024 in fbcode. Here we match the black version in OSS. Differential Revision: D56340613
aakhundov
force-pushed
the
export-D56340613
branch
from
435d265 to
be21733
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56340613 |
houseroad
reviewed
Apr 19, 2024
| @@ -87,6 +87,11 @@ def _find_fusion_root(tensor: Tensor, fusion_patterns: List[Any]) -> int: | |||
| dst_op_tensor = dst_op._attrs["outputs"] | |||
| if len(dst_op_tensor) != 1: | |||
| break | |||
| if dst_op_tensor[0]._attrs["is_output"]: | |||
There was a problem hiding this comment.
No, this was exported from other diff. Let me disconnect this one and re-export.
aakhundov
added a commit
to aakhundov/AITemplate-1
that referenced
this pull request
Apr 19, 2024
Summary: There are some [linter errors](https://github.com/facebookincubator/AITemplate/actions/runs/8680791999/job/23802124952) in OSS trunk caused by D54447738 updating black version to 2024 in fbcode. Here we match the black version in OSS. Reviewed By: hl475 Differential Revision: D56340613
aakhundov
force-pushed
the
export-D56340613
branch
from
be21733 to
cf6ac86
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56340613 |
aakhundov
added a commit
to aakhundov/AITemplate-1
that referenced
this pull request
Apr 19, 2024
Summary: There are some [linter errors](https://github.com/facebookincubator/AITemplate/actions/runs/8680791999/job/23802124952) in OSS trunk caused by D54447738 updating black version to 2024 in fbcode. Here we match the black version in OSS. Reviewed By: hl475 Differential Revision: D56340613
aakhundov
force-pushed
the
export-D56340613
branch
from
cf6ac86 to
3bbd749
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56340613 |
Summary: There are some [linter errors](https://github.com/facebookincubator/AITemplate/actions/runs/8680791999/job/23802124952) in OSS trunk caused by D54447738 updating black version to 2024 in fbcode. Here we match the black version in OSS. Reviewed By: hl475 Differential Revision: D56340613
aakhundov
force-pushed
the
export-D56340613
branch
from
3bbd749 to
696e19e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56340613 |
|
This pull request has been merged in 0973303. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: There are some linter errors in OSS trunk caused by D54447738 updating black version to 2024 in fbcode. Here we match the black version in OSS.
Differential Revision: D56340613