-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a couple of dynamic shape detection issues #996
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Mar 17, 2024
This pull request was exported from Phabricator. Differential Revision: D54831007 |
chenyang78
added a commit
to chenyang78/AITemplate-fb-incubator
that referenced
this pull request
Mar 17, 2024
Summary: This diff fixed a couple of issues for dynamic shape detection: * handle cases where sample tensors may not have any dynamic dimension * added two lowering configs to guide dynamic shape detection (1) can_last_dim_be_dynamic: specifies if the last dimension can be dynamic (2) can_value_one_be_dynamic: specifies if dimension value one is allowed to appear at any dynamic dimension Differential Revision: D54831007
chenyang78
force-pushed
the
export-D54831007
branch
from
March 17, 2024 20:56
c2cf4c0
to
a1c2ecd
Compare
This pull request was exported from Phabricator. Differential Revision: D54831007 |
chenyang78
added a commit
to chenyang78/AITemplate-fb-incubator
that referenced
this pull request
Mar 18, 2024
Summary: This diff fixed a couple of issues for dynamic shape detection: * handle cases where sample tensors may not have any dynamic dimension * added two lowering configs to guide dynamic shape detection (1) can_last_dim_be_dynamic: specifies if the last dimension can be dynamic (2) can_value_one_be_dynamic: specifies if dimension value one is allowed to appear at any dynamic dimension Differential Revision: D54831007
chenyang78
force-pushed
the
export-D54831007
branch
from
March 18, 2024 08:10
a1c2ecd
to
9ed765a
Compare
This pull request was exported from Phabricator. Differential Revision: D54831007 |
Summary: This diff fixed a couple of issues for dynamic shape detection: * handle cases where sample tensors may not have any dynamic dimension * added two lowering configs to guide dynamic shape detection (1) can_last_dim_be_dynamic: specifies if the last dimension can be dynamic (2) can_value_one_be_dynamic: specifies if dimension value one is allowed to appear at any dynamic dimension Differential Revision: D54831007
chenyang78
force-pushed
the
export-D54831007
branch
from
March 19, 2024 02:37
9ed765a
to
0cf0bd6
Compare
This pull request was exported from Phabricator. Differential Revision: D54831007 |
This pull request has been merged in d2dc957. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff fixed a couple of issues for dynamic shape detection:
handle cases where sample tensors may not have any dynamic dimension
added two lowering configs to guide dynamic shape detection
(1) can_last_dim_be_dynamic: specifies if the last dimension can be dynamic
(2) can_value_one_be_dynamic: specifies if dimension value one is allowed
to appear at any dynamic dimension
Differential Revision: D54831007